-
Notifications
You must be signed in to change notification settings - Fork 1
Make dry run tests more extensive #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c4b40d2
fix dry run testing
Dhananjhay bd4f5a0
replace hipp with autoafids
Dhananjhay b529abf
make dry run tests more extensive
Dhananjhay 3aec9b5
configure dry run testing for different modalities
Dhananjhay 0af7801
rename tests/data to test_data
Dhananjhay e804a3b
rename tests_data to test_data
Dhananjhay 2c29b66
change ct to CT
Dhananjhay df7f82d
change CT to ct
Dhananjhay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| --- | ||
| # This workflow will install Python dependencies, run tests and lint with a variety of Python versions | ||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
|
|
||
| name: Lint and test workflow | ||
| on: | ||
| push: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| quality: | ||
| name: Lint code | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Install non-python dependencies | ||
| run: | | ||
| sudo apt-get install -y graphviz-dev | ||
|
|
||
| - name: Setup Python environment | ||
| uses: khanlab/actions/.github/actions/action-setup_task-installPyProject@v0.3.6 | ||
| with: | ||
| python-version: "3.10" | ||
|
|
||
| - name: yamlfix | ||
| run: poetry run poe yamlfix-check | ||
|
|
||
| - name: ruff | ||
| run: poetry run poe ruff-lint-check | ||
|
|
||
| - name: snakefmt | ||
| run: poetry run poe snakefmt-check | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest | ||
| needs: ["quality"] | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.9", "3.10"] | ||
|
|
||
| steps: | ||
| - name: Install non-python dependencies | ||
| run: | | ||
| sudo apt-get install -y graphviz-dev | ||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: khanlab/actions/.github/actions/action-setup_task-installPyProject@v0.3.6 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Setup Python environments | ||
| uses: khanlab/actions/.github/actions/action-setup_task-installPyProject@v0.3.6 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| install-library: true | ||
|
|
||
| - name: Setup env for autoafids | ||
| run: | | ||
| echo "AUTOAFIDS_CACHE_DIR=`pwd`/test_data/autoafids_cache_dir" >> $GITHUB_ENV | ||
|
|
||
| - name: Test T1w modality | ||
| run: | | ||
| poetry run autoafids test_data/bids_T1w test_out participant -np | ||
|
|
||
| - name: Test T2w modality | ||
| run: | | ||
| poetry run autoafids test_data/bids_T2w test_out participant --modality T2w -np | ||
|
|
||
| - name: Test CT modality | ||
| run: | | ||
| poetry run autoafids test_data/bids_ct test_out participant --modality ct -np | ||
|
|
||
| - name: Test stereotaxy feature with T1w modality | ||
| run: | | ||
| poetry run autoafids test_data/bids_T1w test_out participant --stereotaxy STN -np | ||
|
|
||
| - name: Test stereotaxy feature with T2w modality | ||
| run: | | ||
| poetry run autoafids test_data/bids_T2w test_out participant --stereotaxy STN --modality T2w -np | ||
|
|
||
| - name: Test fidqc feature | ||
| run: | | ||
| poetry run autoafids test_data/bids_T1w test_out participant --fidqc -np | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,7 @@ pybids_inputs: | |
| - reconstruction | ||
| - run | ||
|
|
||
| CT: | ||
| ct: | ||
| filters: | ||
| suffix: ct | ||
| extension: .nii.gz | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Empty file.
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the AUTOAFIDS_CACHE_DIR, I think if we combine the dry and wet runs it will be overwritten for the model cache dir in the wet run. Will this be alright or was this section added to cache the setup environment
(dependencies etc.)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this from my code - not longer a conflict!