feat: restore the last-open session when switching workspaces - #416
Merged
Conversation
Switching to a workspace previously landed on a blank new-session page and the session open there last had to be re-picked by hand. Record the selected session per workspace (resolved project root, sharing one slot across worktrees) in localStorage, and on a cross-project cwd change look it up against the live session list to restore it. A deleted or drifted session clears the memory and keeps the welcome page; a failed list fetch keeps the memory for a later retry. A token guard drops stale async restores after a rapid switch sequence.
…e-memory # Conflicts: # components/AppShell.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: restore the last-open session when switching workspaces
Switching to a workspace previously landed on a blank new-session page,
and the session open there last had to be re-picked by hand. This PR
remembers each workspace's last-open session and restores it on switch.
Behavior
project root (all worktrees of one repo share a slot).
after a brief welcome-transition; no memory → default welcome page.
memory cleared silently, welcome page stays.
Implementation
lib/workspace-memory.ts— pure localStorage helpers(
getLastOpenSession/setLastOpenSession/clearLastOpen/workspaceKeyOf), storage injectable for tests.components/AppShell.tsx— record on session select; newrestoreWorkspaceContextcalled fromhandleCwdChange's cross-projectbranch restores the session via the live session list.
Testing
node --test lib/workspace-memory.test.mjs— 11/11 passnode_modules/.bin/tsc --noEmit— cleannpm run lint— clean