fix: forward wrapper shutdown signals to Next child - #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGINTandSIGTERMfrom thepi-webwrapper to the spawned Next.js processValidation
node --experimental-strip-types --test lib/process-lifecycle.test.mjsnpm test(560 tests passed)npm run lintnode_modules/.bin/tsc --noEmitnpm run buildnpm pack --dry-run --jsonSIGTERMsmoke test exits the wrapper with status 143 and leaves no child processFixes #495