Skip to content

fix: renotify repeated completion notifications - #701

Merged
agegr merged 1 commit into
agegr:mainfrom
kuviki:fix/notification-renotify
Sep 5, 2026
Merged

fix: renotify repeated completion notifications#701
agegr merged 1 commit into
agegr:mainfrom
kuviki:fix/notification-renotify

Conversation

@kuviki

@kuviki kuviki commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Repeated completion notifications for the same session reuse a stable notification tag.

Because renotify defaults to false, replacing an existing notification with the same tag may update the notification in the notification center without alerting the user again.

This change enables renotify whenever a notification tag is present, so each new completion alerts the user while still keeping only one notification per session.

Reproduction

  1. Run a task and switch away from Pi Web.
  2. Wait for the completion notification.
  3. Leave the notification in the system notification center.
  4. Run another task in the same session.
  5. The existing notification is replaced, but no new alert/banner is shown.
  6. Dismissing the old notification makes the next completion alert normally again.

Changes

  • Enable renotify: true for tagged Web Push notifications.
  • Apply the same behavior to in-page browser notifications for consistency.

The stable per-session tag is preserved, so repeated completions still do not accumulate duplicate notifications.

@agegr
agegr merged commit edf574a into agegr:main Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants