localjwtauthority: Prep for rotation support - #1313
Open
Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Open
localjwtauthority: Prep for rotation support#1313Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Conversation
Taahir Ahmed (ahmedtd)
requested review from
Shruti Nair (SHRUTI6991) and
Max Thompson (thompsonmax)
August 29, 2026 05:17
* Add a RefreshingPool abstraction like localca.RefreshingPool. This provides caching (so we don't read the keys fresh from the filesystem) for each signing operation. * Extend ConcretePool so that it tracks which key is currently active for signing, instead of always picking the first key. A followup PR will add admin commands for actually rotating the JWT pool.
Taahir Ahmed (ahmedtd)
force-pushed
the
ca-rotation
branch
from
August 29, 2026 05:27
ea0bf18 to
0bc0692
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup PR will add admin commands for actually rotating the JWT pool.