Add a readyz probe to the benchmark glutton actor - #545
Open
Chuang Wang (chuangw6) wants to merge 1 commit into
Open
Add a readyz probe to the benchmark glutton actor#545Chuang Wang (chuangw6) wants to merge 1 commit into
Chuang Wang (chuangw6) wants to merge 1 commit into
Conversation
ResumeActor returned as soon as the resume workflow finished, not when glutton's port 80 listener was accepting connections. A ping issued right after resume could land in that gap, get ECONNREFUSED, and come back from the router as a 503. ateom already has the gate: internal/readyz.WaitAll blocks RestoreWorkload and RunWorkload until every container that declares a readyz probe returns 200. Containers without a probe are skipped entirely, so glutton was never waited on. This adds /readyz to the HTTP mux -- on the same listener as /ping, since the metrics server starts independently and would answer 200 before /ping is reachable -- and points the ActorTemplate at it. Note that ActorTemplate.spec is immutable, so picking this up needs a delete and recreate of the template, not an apply.
Chuang Wang (chuangw6)
force-pushed
the
bench/glutton-readyz
branch
from
July 27, 2026 08:03
4d9b568 to
7de0bdd
Compare
Chuang Wang (chuangw6)
changed the base branch from
bench/boomer-pace-early-exit
to
bench/locust-image-platform
July 27, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ResumeActor returned as soon as the resume workflow finished, not when glutton's port 80 listener was accepting connections. A ping issued right after resume could land in that gap, get ECONNREFUSED, and come back from the router as a 503. At 50 VUs this was roughly 42% of pings.
ateom already has a gate for exactly this:
internal/readyz.WaitAllblocksRestoreWorkloadandRunWorkloaduntil every container that declares a readyz probe returns 200. But containers without a probe are skipped entirely, and glutton declared none, so nothing waited on it.Solution
Add
/readyzto glutton's HTTP mux and point the ActorTemplate at it.The route goes on the same listener as
/pingrather than the metrics port: the metrics server starts independently, so a 200 there would say nothing about whether/pingis reachable yet.Notes
ActorTemplate.specis immutable, so picking this up needs a delete and recreate of the template, not an apply.Stacked on #543.