Build the locust image for the cluster's architecture - #555
Merged
Max Smythe (maxsmythe) merged 1 commit intoJul 29, 2026
Merged
Conversation
Collaborator
|
LGTM once comment nit is fixed |
| IMAGE="us-docker.pkg.dev/${PROJECT_ID}/gcr.io/ate-images/locust-test:latest" | ||
|
|
||
| echo "Building Docker image: $IMAGE" | ||
| # Target platform must match the cluster's nodes, not the build host. Without |
Collaborator
There was a problem hiding this comment.
This comment seems to over-explain things and mentions Google-specific hardware (Axion).
It is sufficient should say "# Target platform must match the cluster's nodes, not the build host"
Collaborator
Author
There was a problem hiding this comment.
SG. Updated
Chuang Wang (chuangw6)
force-pushed
the
bench/locust-image-platform
branch
from
July 29, 2026 00:14
dc7bbfd to
5d7d757
Compare
docker build defaults to the build host's platform. On an Apple Silicon workstation that produces an arm64 image, the push succeeds, and nothing complains until the kubelet on an amd64 node reports no match for platform in manifest: not found two steps later, which reads like a registry or IAM problem rather than a build one. Pin the build to linux/amd64, overridable via LOCUST_IMAGE_PLATFORM for arm64 node pools (T2A, Axion).
Chuang Wang (chuangw6)
force-pushed
the
bench/locust-image-platform
branch
from
July 29, 2026 00:20
5d7d757 to
5fe1475
Compare
Max Smythe (maxsmythe)
approved these changes
Jul 29, 2026
Max Smythe (maxsmythe)
merged commit Jul 29, 2026
29a7ce4
into
agent-substrate:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build_and_push.shrandocker buildwith no--platform, so an arm64workstation produced an arm64 image while GKE nodes (c3-standard-4) are
amd64. The push succeeds and nothing fails until the kubelet pulls, two
steps later:
Solution
Default to
linux/amd64, overridable viaLOCUST_IMAGE_PLATFORMfor arm64node pools (T2A, Axion).
Notes
Verified: pushed manifest reports
linux/amd64and the locust pod reaches3/3 Running.