Support CONNECT in atenet router - #715
Open
Keith Mattix II (keithmattix) wants to merge 11 commits into
Open
Conversation
Keith Mattix II (keithmattix)
marked this pull request as ready for review
August 3, 2026 20:59
Keith Mattix II (keithmattix)
force-pushed
the
ate-router-connect
branch
from
August 4, 2026 00:21
05577ee to
ab56e6e
Compare
Collaborator
|
Bowei Du (@bowei) to route networking PR |
Lior Lieberman (LiorLieberman)
self-requested a review
August 4, 2026 14:56
Collaborator
|
Can you put the vendor change in its own commit (make it obvious) |
Consolidates the vendor/, go.mod, and go.sum changes needed for arbitrary-port CONNECT ingress support into a single commit.
…T terminate listener implementation Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Agentgateway's ext_proc client reads only Value and ignores RawValue, silently applying our RawValue-only mutations as empty-string headers. This broke agentgateway's dynamic routing headers (x-ate-original-dst, X-Ate-Original-Host, :authority, X-Ate-Target-Port) and any immediate error response's content-type header. Newer Envoy versions drop Value in favor of RawValue, so both must be set to work on either dataplane.
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Keith Mattix II (keithmattix)
force-pushed
the
ate-router-connect
branch
from
August 4, 2026 19:59
168bdd4 to
d6ce656
Compare
Author
|
Bowei Du (@bowei) good call - done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #689, #265 and starts to address #484. Implemented all of the xDS by hand and had codex do the extproc bits (need to do another pass on its implementation; there are already some things I'm not happy with). Modifies the ate router to:
#484 is currently blocked because Envoy's implementation of NetworkExternalProcessor doesn't support passing filter state to the extproc server. Dynamic metadata doesn't work because only Host (i.e. endpoint) and cluster metadata can propagate across internal listeners (a necessary implementation detail of doing CONNECT in Envoy). This PR still adds the xDS for it; the extproc calls just fail because there's no metadata.
Open questions:
Tested 6 scenarios locally:
Once #652 merges, I can add the agentgateway implementationAdded and tested agentgateway implementation as well