Skip to content

Fix failed test TestUploadLocalCheckpointDir - #857

Merged
Benjamin Elder (BenTheElder) merged 2 commits into
agent-substrate:mainfrom
zoez7:fix/atelet-pause-image-fixtures
Aug 11, 2026
Merged

Fix failed test TestUploadLocalCheckpointDir#857
Benjamin Elder (BenTheElder) merged 2 commits into
agent-substrate:mainfrom
zoez7:fix/atelet-pause-image-fixtures

Conversation

@zoez7

@zoez7 Zoe Zhao (zoez7) commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Commit da8414b made unmarshalSandboxRecord reject records without a pauseImage, fixing the test failure found in

--- FAIL: TestUploadLocalCheckpointDir (0.01s)
    --- FAIL: TestUploadLocalCheckpointDir/matching_scope_uploads_all_files (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/microvm_full_capture_uploads_durable_tar_alone_as_data (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/gvisor_full_capture_cannot_become_data_yet (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/microvm_full_capture_without_durable_tar_has_no_data (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/unknown_sandbox_class_cannot_convert (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/data_capture_cannot_become_full (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/manifest_without_scope_is_rejected (0.00s)
    --- PASS: TestUploadLocalCheckpointDir/gone_locally_but_already_uploaded_succeeds (0.00s)
    --- PASS: TestUploadLocalCheckpointDir/gone_locally_and_remotely_crashes_the_actor (0.00s)
    --- FAIL: TestUploadLocalCheckpointDir/upload_failure_is_a_plain_retryable_error (0.00s)

@zoez7
atelet: add pauseImage to TestUploadLocalCheckpointDir fixtures
27fcf9e 
Commit da8414b made unmarshalSandboxRecord reject records without a
pauseImage but missed these fixtures, so every subtest that parses the
local manifest failed early with DataLoss instead of exercising its
intended path.
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 11, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates cmd/atelet/main_test.go by adding the PauseImage field with a placeholder value ("pause@sha256:abc") to multiple sandboxAssetsRecord test fixtures within TestUploadLocalCheckpointDir. There are no review comments to evaluate, and I have no feedback to provide.

@zoez7 Zoe Zhao (zoez7) mentioned this pull request Aug 11, 2026
Open
BenTheElder
Benjamin Elder (BenTheElder) reviewed Aug 11, 2026
View reviewed changes
Comment thread cmd/atelet/main_test.go Outdated
@BenTheElder
Benjamin Elder (BenTheElder) merged commit e5ea186 into agent-substrate:main Aug 11, 2026
10 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder Benjamin Elder (BenTheElder) BenTheElder approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoez7 @BenTheElder