Delete namespaces on test completion - #904
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoAug 12, 2026
Merged
Conversation
sfunkenhauser
marked this pull request as ready for review
August 12, 2026 20:54
sfunkenhauser
requested review from
Benjamin Elder (BenTheElder) and
Zoe Zhao (zoez7)
August 12, 2026 20:54
| } | ||
|
|
||
| // Release the namespace as soon as this test is done rather than at the end of | ||
| // the run. A suite's namespaces each carry a WorkerPool, and its worker pods |
Collaborator
There was a problem hiding this comment.
We also might need to revisit that, or seriously downsize them or ...
Benjamin Elder (BenTheElder)
approved these changes
Aug 12, 2026
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
thanks! this should help with flakiness, cc Eitan Yarmush (@EItanya)
Benjamin Elder (BenTheElder)
merged commit Aug 12, 2026
19fc57b
into
agent-substrate:main
11 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E test WorkerPools (and thus pods) weren't cleaned up until all tests were finished running. This resulted in resource exhaustion and pods not being scheduled. If a test completes successfully delete the namespace immediately.