chore(deps): memory-core 0.3.2 - commit lock-retry - #237
Merged
Conversation
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
@agentage/memory-core^0.3.1->^0.3.2to pick up the LocalBackendcommit lock-retry (memory-core#19/#20): a transient
git commit failedunder aconcurrent write + sync storm is now retried inside the engine, so the daemon's
directly-spawned sync
gitno longer races the engine's commit into a spuriousfailure.
Scope
Targeted bump only. The lock diff touches only
@agentage/memory-core:package.json:^0.3.1->^0.3.2package-lock.jsonroot dep +node_modules/@agentage/memory-core:0.3.1->0.3.2@agentage/memory-core@0.1.3under@agentage/server-memory(pinned^0.1.3) is unchangedNo other packages moved; the runtime dep set is identical (package-guard green).
Verify
npm run verifygreen - 337 tests pass, build clean.@couchhermetic dockertier:
daemon m1-requirements mcp-daemon mcp-stdio memory-offline sync vault-offline integrity mcp-contract account-vault couch-sync.Note - concurrency assertion deliberately not added
Considered tightening
integrity/couchto assert zero transientgit commit/sync failederrors under a write+sync storm. Skipped it: it's anegative, timing-dependent assertion whose real risk is a false RED (the
lock-retry is bounded; contended runners could exhaust it), and transient sync
errors are "recorded, not crashed" so surfacing them deterministically at the
e2e level is indirect/vacuous. The existing integrity tests already lock the
structural invariants the fix protects (clean tree, no
index.lock,fsckclean under 10/30 concurrent ops) and
couch-syncexercises concurrentwrite+sync convergence - all green on 0.3.2. Kept this a clean one-line bump.