Skip to content

fix(sdk): fail closed on post-hook evaluation errors#114

Merged
lan17 merged 2 commits intomainfrom
codex/fix-112-post-hook-fail-closed
Mar 12, 2026
Merged

fix(sdk): fail closed on post-hook evaluation errors#114
lan17 merged 2 commits intomainfrom
codex/fix-112-post-hook-fail-closed

Conversation

@lan17
Copy link
Contributor

@lan17 lan17 commented Mar 11, 2026

Summary

  • make unexpected post-hook control evaluation failures fail closed instead of only logging
  • route pre/post hook evaluation through a shared helper so the enforcement policy stays consistent
  • add a regression test covering post-hook RuntimeError behavior

Testing

  • make sdk-typecheck
  • make sdk-test

Closes #112

@lan17 lan17 changed the title fix: fail closed on post-hook evaluation errors fix(sdk): fail closed on post-hook evaluation errors Mar 12, 2026
@lan17 lan17 enabled auto-merge (squash) March 12, 2026 00:09
Copy link
Contributor

@namrataghadi-galileo namrataghadi-galileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEts start with fail-closed. If the response is to have it fail open, we can change it later.

@lan17 lan17 disabled auto-merge March 12, 2026 00:17
@lan17 lan17 merged commit 67f8fc1 into main Mar 12, 2026
5 of 6 checks passed
@lan17 lan17 deleted the codex/fix-112-post-hook-fail-closed branch March 12, 2026 00:17
galileo-automation pushed a commit that referenced this pull request Mar 18, 2026
## [2.0.0](ts-sdk-v1.1.0...ts-sdk-v2.0.0) (2026-03-18)

### ⚠ BREAKING CHANGES

* **server:** implement recursive control condition trees (#115)

### Features

* **docs:** simplify main README quick start v2 ([#100](#100)) ([7701c65](7701c65))
* **docs:** Update README.md to accurately mention Strands Agents SDK ([#105](#105)) ([84dfa57](84dfa57))
* **evaluators:** add Cisco AI Defense evaluator and examples ([#60](#60)) ([52e2416](52e2416))
* **sdk:** add Google ADK framework integration ([#83](#83)) ([f2b53ee](f2b53ee))
* **server:** implement recursive control condition trees ([#115](#115)) ([2ff4c12](2ff4c12))

### Bug Fixes

* **docs:** clarify README quickstart flow ([#119](#119)) ([317c626](317c626))
* **docs:** cleanup readme ([#66](#66)) ([eca0d6b](eca0d6b))
* **docs:** promote Google ADK plugin in README ([#99](#99)) ([f038aa4](f038aa4))
* **evaluators:** address Cisco AI Defense review issues ([#103](#103)) ([81da81b](81da81b))
* **examples:** shut down SDK in short-lived demos ([#85](#85)) ([df43264](df43264))
* **sdk:** fail closed on post-hook evaluation errors ([#114](#114)) ([67f8fc1](67f8fc1)), closes [#112](#112)
* **sdk:** skip evaluation when no controls apply ([#124](#124)) ([d2cd9f9](d2cd9f9))
* **server:** escape ILIKE pattern in evaluator-configs list endpoint ([#108](#108)) ([cb6e89f](cb6e89f))
* **server:** reject empty string list evaluator values ([#121](#121)) ([2c55d27](2c55d27))
* **server:** revert unwanted changes in server config ([#117](#117)) ([d92e168](d92e168))
* **ui:** create flow - name trimming issue ([#93](#93)) ([1a9759d](1a9759d))
@galileo-automation
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

3 participants