feat: add lazy-aware JSON Schema conversion and regression tests for zod integration by alexmercerpo · Pull Request #498 · agentfront/frontmcp

alexmercerpo · 2026-06-21T23:38:55Z

Summary by CodeRabbit

Bug Fixes
- Fixed JSON Schema generation for lazy Zod schemas by ensuring lazy/proxy schemas are fully realized before conversion, preventing failures and preserving expected schema structure.
Tests
- Added a new test suite covering lazy-aware toJSONSchema behavior, including optional/union handling, correct required fields for optional object properties, and idempotent conversion.

…zod integration

coderabbitai · 2026-06-21T23:39:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5825f627-7f15-4766-a682-62aa383efedd

📥 Commits

Reviewing files that changed from the base of the PR and between cba04d0 and ddb8a95.

📒 Files selected for processing (1)

libs/lazy-zod/src/__tests__/to-json-schema.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

libs/lazy-zod/src/tests/to-json-schema.spec.ts

📝 Walkthrough

Walkthrough

toJSONSchema in libs/lazy-zod/src/index.ts is changed from a direct re-export of zod's function to a local wrapper that calls forceMaterialize(schema) before delegating to zod's converter. A new test file adds four tests covering optional unions, arrays of objects, idempotency, and plain schema conversion.

Changes

lazy-zod toJSONSchema wrapper and tests

Layer / File(s)	Summary
toJSONSchema materialization wrapper `libs/lazy-zod/src/index.ts`	Adds imports of `toJSONSchema` (aliased as `zodToJSONSchema`), `ZodType`, and `forceMaterialize`. Replaces the direct re-export with a locally defined `export const toJSONSchema` that calls `forceMaterialize(schema)` before delegating to `zodToJSONSchema`, with casting to preserve upstream typing.
Test suite for lazy-aware toJSONSchema `libs/lazy-zod/src/__tests__/to-json-schema.spec.ts`	Adds a `describe` block with four tests: optional union conversion asserting `anyOf` shape and `required` fields; array-of-objects conversion asserting item `required` fields; idempotency of repeated calls; and baseline conversion of a plain Zod string schema.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 A lazy proxy tried to sneak,
Through JSON Schema's parsing streak.
But forceMaterialize said "Not today!"
And turned that phantom schema real.
Now tests run true, no more ordeal! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: add lazy-aware JSON Schema conversion and regression tests for zod integration' accurately describes the main changes: adding a lazy-aware wrapper for toJSONSchema and comprehensive test coverage for the lazy-zod integration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-zod-schema

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

libs/lazy-zod/src/index.ts (1)
39-43: 🧹 Nitpick | 🔵 Trivial

Clarify registry support: the wrapper does not auto-materialize lazy schemas within a registry parameter.

Zod v4's toJSONSchema does not have a registry overload; the registry is passed via the params object (second argument). The current wrapper materializes only the schema argument, not lazy schemas nested within a registry passed as params.registry. While no current code uses this pattern, add a test covering registry-based toJSONSchema() calls with lazy schemas, or document that registry support is intentionally unsupported if lazy schemas are present.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/lazy-zod/src/index.ts` around lines 39 - 43, The `toJSONSchema` wrapper
function at line 39-43 only materializes the schema argument via
forceMaterialize(), but does not handle lazy schemas that may be nested within a
registry object passed as part of the params parameter. Either add a test case
that calls `toJSONSchema` with a registry parameter containing lazy schemas to
demonstrate the current behavior, or add a JSDoc comment to the function
clarifying that lazy schemas within a registry are not automatically
materialized and documenting this as an intentional limitation.
Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@libs/lazy-zod/src/__tests__/to-json-schema.spec.ts`:
- Around line 26-32: Replace the `Record<string, any>` type cast with a stricter
type annotation (use `unknown` or a properly defined schema type) to maintain
strict TypeScript correctness. Additionally, update the test cases to use the
explicit eager Zod export `eagerZ` instead of the current schema definition for
the real-schema cases. Apply this strict-typing cleanup to all locations
mentioned in the comment (lines 26-32, 49-54, and 69-72) to ensure consistent
and type-safe test assertions throughout the file.

---

Nitpick comments:
In `@libs/lazy-zod/src/index.ts`:
- Around line 39-43: The `toJSONSchema` wrapper function at line 39-43 only
materializes the schema argument via forceMaterialize(), but does not handle
lazy schemas that may be nested within a registry object passed as part of the
params parameter. Either add a test case that calls `toJSONSchema` with a
registry parameter containing lazy schemas to demonstrate the current behavior,
or add a JSDoc comment to the function clarifying that lazy schemas within a
registry are not automatically materialized and documenting this as an
intentional limitation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5eda332f-e7a6-41a4-b321-418b4c470d77

📥 Commits

Reviewing files that changed from the base of the PR and between c1740dc and cba04d0.

📒 Files selected for processing (2)

libs/lazy-zod/src/__tests__/to-json-schema.spec.ts
libs/lazy-zod/src/index.ts

github-actions · 2026-06-21T23:51:51Z

Performance Test Results

Status: ✅ All tests passed

Summary

Project	Tests	Passed
✅ demo-e2e-agents	4	4
✅ demo-e2e-cache	11	11
✅ demo-e2e-codecall	4	4
✅ demo-e2e-config	4	4
✅ demo-e2e-direct	3	3
✅ demo-e2e-elicitation	1	1
✅ demo-e2e-errors	4	4
✅ demo-e2e-hooks	3	3
✅ demo-e2e-multiapp	4	4
✅ demo-e2e-notifications	3	3
✅ demo-e2e-openapi	2	2
✅ demo-e2e-providers	4	4
✅ demo-e2e-public	4	4
✅ demo-e2e-redis	15	15
✅ demo-e2e-remember	4	4
✅ demo-e2e-remote	5	5
✅ demo-e2e-serverless	2	2
✅ demo-e2e-skills	15	15
✅ demo-e2e-standalone	2	2
✅ demo-e2e-transport-recreation	3	3
✅ demo-e2e-ui	4	4

Total: 101 tests across 21 projects

📊 View full report in workflow run

Generated at: 2026-06-22T08:47:38.668Z
Commit: 7d126250

…zod integration

github-actions · 2026-06-22T08:53:43Z

Cherry-pick Created

A cherry-pick PR to main has been automatically created.

Please review and merge if this change should also be in main.

If the cherry-pick is not needed, close the PR.

…on tests for zod integration (#499) Cherry-picked from #498 (merged to release/1.5.x) Original commit: adaa276 Co-authored-by: agentfront[bot] <agentfront[bot]@users.noreply.github.com> Co-authored-by: alexmercerpo <251740932+alexmercerpo@users.noreply.github.com>

feat: add lazy-aware JSON Schema conversion and regression tests for …

cba04d0

…zod integration

alexmercerpo requested a review from frontegg-david June 21, 2026 23:38

frontegg-david approved these changes Jun 21, 2026

View reviewed changes

coderabbitai Bot reviewed Jun 21, 2026

View reviewed changes

Comment thread libs/lazy-zod/src/__tests__/to-json-schema.spec.ts Outdated

feat: add lazy-aware JSON Schema conversion and regression tests for …

ddb8a95

…zod integration

frontegg-david merged commit adaa276 into release/1.5.x Jun 22, 2026
37 checks passed

frontegg-david deleted the fix-zod-schema branch June 22, 2026 08:53

github-actions Bot mentioned this pull request Jun 22, 2026

Cherry-pick: feat: add lazy-aware JSON Schema conversion and regression tests for zod integration #499

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add lazy-aware JSON Schema conversion and regression tests for zod integration#498

feat: add lazy-aware JSON Schema conversion and regression tests for zod integration#498
frontegg-david merged 2 commits into
release/1.5.xfrom
fix-zod-schema

alexmercerpo commented Jun 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

alexmercerpo commented Jun 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance Test Results

Summary

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Cherry-pick Created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexmercerpo commented Jun 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 21, 2026 •

edited

Loading

github-actions Bot commented Jun 21, 2026 •

edited

Loading