Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/core/src/git/GitService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,8 @@ import { gitHttpClient } from './GitHttpClient';

// HTTP client adapter - bridges our implementation to isomorphic-git's HttpClient type
// Our implementation uses AsyncIterableIterator which works with isomorphic-git at runtime
const http: HttpClient = async (url, options) => {
// Delegate to the underlying implementation; types differ slightly but are runtime compatible
const response = await gitHttpClient(url, options as any);
return {
...response,
// Localize the type assertion to the known body-type difference
body: (response as any).body,
};
};
// Using type assertion as the body types differ but are compatible at runtime
const http = gitHttpClient as unknown as HttpClient;

import type {
BranchInfo,
Expand Down
22 changes: 7 additions & 15 deletions scripts/check-expo-compatibility.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
* Exit code is always 0 (informational) since incompatibility is intentional.
*/

const fs = require('fs');
const path = require('path');
const fs = require('node:fs');
const path = require('node:path');

// Known Expo Go incompatible dependencies
const INCOMPATIBLE_DEPENDENCIES = {
Expand Down Expand Up @@ -84,8 +84,7 @@ function checkAppConfig(projectRoot) {
reports.push({
category: 'Configuration',
item: 'app.config.ts',
reason:
'Uses TypeScript config which may contain dynamic native plugins',
reason: 'Uses TypeScript config which may contain dynamic native plugins',
});
}

Expand All @@ -98,19 +97,15 @@ function checkAppConfig(projectRoot) {
reports.push({
category: 'Configuration',
item: 'newArchEnabled: true',
reason:
'React Native New Architecture requires custom builds (not Expo Go)',
reason: 'React Native New Architecture requires custom builds (not Expo Go)',
});
}

// Check for native config plugins
const plugins = appConfig.expo.plugins || [];
for (const plugin of plugins) {
const pluginName = Array.isArray(plugin) ? plugin[0] : plugin;
if (
typeof pluginName === 'string' &&
NATIVE_CONFIG_PLUGINS.includes(pluginName)
) {
if (typeof pluginName === 'string' && NATIVE_CONFIG_PLUGINS.includes(pluginName)) {
reports.push({
category: 'Config Plugin',
item: pluginName,
Expand All @@ -134,8 +129,7 @@ function checkEasJson(projectRoot) {
reports.push({
category: 'EAS Configuration',
item: 'developmentClient: true',
reason:
'Explicitly configured for development client builds (not Expo Go)',
reason: 'Explicitly configured for development client builds (not Expo Go)',
});
}

Expand All @@ -155,9 +149,7 @@ function printReport(reports) {
return;
}

console.log(
`⚠️ Found ${reports.length} Expo Go incompatibilities (this is expected):\n`
);
console.log(`⚠️ Found ${reports.length} Expo Go incompatibilities (this is expected):\n`);

// Group by category
const grouped = reports.reduce((acc, report) => {
Expand Down
2 changes: 1 addition & 1 deletion src/services/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export {
type PullOptions,
type PushOptions,
type RemoteInfo,
type RepositoryStatus,
type RetrieveOptions,
type RepositoryState,
type StageOptions,
type StoreOptions,
type ValidationResult,
Expand Down
Loading