feat: add lsp_defs/refs to all schemas + Rust/Terraform presets#82
Merged
jamestexas merged 2 commits intomainfrom Mar 12, 2026
Merged
feat: add lsp_defs/refs to all schemas + Rust/Terraform presets#82jamestexas merged 2 commits intomainfrom
jamestexas merged 2 commits intomainfrom
Conversation
Complete the LSP materialization story: add definitions and references content sources alongside existing hover and diagnostics. Create preset schemas for Rust (10 construct types) and Terraform/HCL (7 construct types) so they use structured trees instead of FCA inference fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The serve command was calling os.ReadFile directly on the --schema value, bypassing preset lookup. Now uses resolveSchema() which checks presets first, matching the behavior of the config system. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lsp_defs(definitions) andlsp_refs(references) content sources to thelspfile_set across all language schemas, completing the LSP materialization story alongside existing hover and diagnosticsimpl_item type:for impl blocks#eq?predicates to distinguish block typessourceCodePresetsandpresetSchemasso auto-detection uses them instead of FCA inferenceserve --schemato useresolveSchema()for preset name support (was callingos.ReadFiledirectly)Test plan
task testβ all existing tests pass includingTestResolveSchema_AllPresets(rust + terraform)TestSourceCodePresets_SubsetOfPresetSchemasvalidates all preset keys resolvemache serveon ley-line/rs with Rust preset β 791 functions, 52 structs, 15 enums, 2 traits, 50 implementations verified via MCP tools.tffiles β validate#eq?predicatesleyline lspenrichment β verify definitions/references files materializeπ€ Generated with Claude Code