fix: pre-release review — 7 surgical fixes#100
Merged
jamestexas merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
1. fix(serve): sanitize symbol input in daemon SQL queries to prevent injection
2. fix(vfs): resolver falls through to next handler when Match succeeds but
Stat returns nil — prevents real graph nodes named "context"/"location"
from being hidden by virtual file handlers
3. fix(ci): release.yml repository_dispatch condition now checks
client_payload.tag so leyline-triggered releases actually publish
4. fix(graph): WritableGraph.ListChildren selects id instead of name,
matching SQLiteGraph behavior for correct path resolution
5. fix(serve): graphRegistry.Close() calls cleanup on all lazy graphs,
wired via defer in runServe to prevent SQLite connection leaks in HTTP mode
6. fix(serve): signal handler for SIGTERM/SIGINT ensures managed leyline
daemon is stopped even when process is killed rather than exiting cleanly
7. fix(serve): cap batch read_file to 100 paths to prevent unbounded requests
Beads: mache-5c416f, mache-5c4c3b, mache-5c5366, mache-5c5a44,
mache-5c6836, mache-5c6f1b, mache-5c76b3
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release audit found 7 issues (3 blockers, 4 should-fix). All resolved in this PR:
symbolparameter sanitized before interpolation into SQL sent over UDSMatchsucceeds butStatreturns nilrepository_dispatchnever creates a release (P0) — Condition now checksclient_payload.tagnameinstead ofid(P1) — Fixed to match SQLiteGraphgraphRegistry.Close(), deferred inrunServeBeads: mache-5c416f, mache-5c4c3b, mache-5c5366, mache-5c5a44, mache-5c6836, mache-5c6f1b, mache-5c76b3
Changes since v0.5.6 (24 commits)
Test plan
task build— compiles cleantask test— all tests passcontextpackage🤖 Generated with Claude Code