fix: correctness debt — 4 surgical bug fixes#92
Merged
jamestexas merged 2 commits intomainfrom Mar 13, 2026
Merged
Conversation
…ssertion - writable_graph.go: check rows.Err() after ListChildren iteration (mache-j5x) - root.go: log UpdateNodeContent error instead of discarding it (mache-jr6) - writable_graph.go: re-check cache after lock reacquire to prevent duplicate contentKeys entries and unbounded cache growth (mache-4l9) - sqlite_graph.go: comma-ok type assertion in setNestedField to prevent panic when dotted path overwrites a scalar with a nested map (mache-p73) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- composite.go: sort mount names for deterministic root ListChildren (mache-dgg) - sqlite_resolver.go: return error when JSON record is not a map instead of silently producing empty template renders (mache-shf) - linter.go: defer QueryCursor.Close() to prevent tree-sitter resource leak (mache-lyf) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four surgical fixes for correctness issues identified in mache scan:
ListChildrenmissingrows.Err()check — database errors during iteration were silently lostUpdateNodeContenterror swallowed during writeback — source file modified but graph left stale with no indicationresolveContentFIFO cache race — concurrent goroutines could insert duplicatecontentKeysentries, causing unbounded cache growthsetNestedFieldunchecked type assertion — panics when a dotted path likea.b.coverwrites an intermediate scalarTest plan
task test— all tests passtask lint— 0 issues🤖 Generated with Claude Code