feat(delivery): add phase orchestration workflow - #113
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughWalkthroughAdds an orchestration skill and phase-delivery documentation, formalizes worktree and candidate-evidence rules, adds skill evaluation assets, and replaces candidate sealing with registered-worktree and manifest validation. ChangesPhase orchestration contract
Evidence and review contract
Single-story boundary constraints
Skill evaluation validation
Repository checks and package transition
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0c85e3c22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/orchestrate-phase-delivery/README.md:
- Line 20: Update the skill-validator instruction in the
orchestrate-phase-delivery README to replace the unresolved <open-skill-creator>
placeholder with either a documented prerequisite that defines its location or a
concrete command runnable from the repository. Keep the validation target and
intended validator invocation unchanged.
In @.agents/skills/orchestrate-phase-delivery/references/phase-protocol.md:
- Around line 57-61: Update the reattach command in the worktree recovery
procedure to use the force option when invoking git worktree add. Keep the
existing prerequisites for verifying the recorded branch/object, registered
path, ledger, base, evidence, and clean state before reattaching.
In @.agents/skills/orchestrate-phase-delivery/scripts/validate_evals.py:
- Around line 36-50: Update the output-case validation in the cases loop to
require nonempty strings for id, prompt, and expected_output, rather than only
truthy values; keep the existing assertions and files checks intact. Validate
IDs before constructing case_ids or deduplicating with set so malformed or
unhashable IDs produce the existing validation failure instead of a TypeError.
In @.agents/skills/orchestrate-phase-delivery/SKILL.md:
- Around line 8-10: Update the required-input step in the phase orchestration
skill to resolve the current approved product package from docs/product/ and
approved architecture package from docs/redesign/design/ before reading or
relying on delivery-policy.md, story-contract.md, track.json, or
phase-orchestration.md. Preserve the existing checks for external activation and
ledger records, and ensure track or Git evidence cannot override product intent
or approved design.
In `@docs/delivery/greenfield/reviewer/review-checklist.md`:
- Around line 105-106: The Q/R/P refresh rule in the “Approved P = Q + durable R
identifier + PASS” checklist bullet is too broad. Qualify the
add/remove/rename/mode/byte drift requirement to changes in the approved package
Q/P, preserving the later rule for source, configuration, and evidence changes
that creates a new candidate with affected checks and review.
- Around line 149-151: Update the post-“Accepted” continuation-evidence
checklist wording so that drift requires affected checks, replacing “any drift
received affected checks” with clear mandatory-response language while
preserving the surrounding conditions and same-reviewer incremental review
guidance.
In `@scripts/check-delivery-track.mjs`:
- Around line 762-770: Update candidatePackagePaths() to include
scripts/check-active-repository.test.mjs alongside the existing validator tests,
adjust the manifest’s exact path count and uniqueness validation to the new
total, and add the same path to the corresponding test fixture so
active-repository test changes invalidate approved Q/P.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a0e5dc2b-f32f-479e-98e5-1f47ca622f87
📒 Files selected for processing (25)
.agents/skills/orchestrate-phase-delivery/README.md.agents/skills/orchestrate-phase-delivery/SKILL.md.agents/skills/orchestrate-phase-delivery/evals/evals.json.agents/skills/orchestrate-phase-delivery/evals/trigger_queries.json.agents/skills/orchestrate-phase-delivery/references/phase-protocol.md.agents/skills/orchestrate-phase-delivery/scripts/validate_evals.pydocs/delivery/AGENTS.mddocs/delivery/README.mddocs/delivery/greenfield/README.mddocs/delivery/greenfield/delivery-policy.mddocs/delivery/greenfield/dependency-dag.mddocs/delivery/greenfield/phase-handoff-template.mddocs/delivery/greenfield/phase-orchestration.mddocs/delivery/greenfield/reviewer/README.mddocs/delivery/greenfield/reviewer/review-checklist.mddocs/delivery/greenfield/risks-and-owner-decisions.mddocs/delivery/greenfield/story-contract.mddocs/delivery/greenfield/verification.mdpackage.jsonscripts/check-active-repository.mjsscripts/check-active-repository.test.mjsscripts/check-delivery-track.mjsscripts/check-delivery-track.test.mjsscripts/seal-candidate.mjsscripts/seal-candidate.test.mjs
💤 Files with no reviewable changes (2)
- scripts/seal-candidate.mjs
- scripts/seal-candidate.test.mjs
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/orchestrate-phase-delivery/SKILL.md:
- Around line 20-23: Update the phase delivery workflow around the pre-check
residue capture to add a final post-review snapshot before merge. Record
tracked/untracked status and the exact output of git ls-files --others --ignored
--exclude-standard, binding this residue evidence to the reviewed candidate
alongside the existing inventories and allowlist decisions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3bd043d6-b42a-46f2-89e5-604b1cec08e5
📒 Files selected for processing (28)
.agents/skills/orchestrate-phase-delivery/SKILL.md.agents/skills/orchestrate-phase-delivery/evals/evals.json.agents/skills/orchestrate-phase-delivery/references/phase-protocol.mddocs/delivery/greenfield/delivery-policy.mddocs/delivery/greenfield/phase-handoff-template.mddocs/delivery/greenfield/phase-orchestration.mddocs/delivery/greenfield/reviewer/README.mddocs/delivery/greenfield/reviewer/review-checklist.mddocs/delivery/greenfield/stories/GF-001.mddocs/delivery/greenfield/stories/GF-002.mddocs/delivery/greenfield/stories/GF-005.mddocs/delivery/greenfield/stories/GF-015.mddocs/delivery/greenfield/stories/GF-021.mddocs/delivery/greenfield/stories/GF-024.mddocs/delivery/greenfield/stories/GF-025.mddocs/delivery/greenfield/stories/GF-026.mddocs/delivery/greenfield/stories/GF-030.mddocs/delivery/greenfield/stories/GF-040.mddocs/delivery/greenfield/stories/GF-041.mddocs/delivery/greenfield/stories/GF-043.mddocs/delivery/greenfield/stories/GF-044.mddocs/delivery/greenfield/stories/GF-046.mddocs/delivery/greenfield/stories/GF-050.mddocs/delivery/greenfield/stories/GF-053.mddocs/delivery/greenfield/story-contract.mddocs/delivery/greenfield/verification.mdscripts/check-delivery-track.mjsscripts/check-delivery-track.test.mjs
🚧 Files skipped from review as they are similar to previous changes (10)
- .agents/skills/orchestrate-phase-delivery/evals/evals.json
- docs/delivery/greenfield/phase-handoff-template.md
- .agents/skills/orchestrate-phase-delivery/references/phase-protocol.md
- docs/delivery/greenfield/verification.md
- scripts/check-delivery-track.test.mjs
- scripts/check-delivery-track.mjs
- docs/delivery/greenfield/phase-orchestration.md
- docs/delivery/greenfield/delivery-policy.md
- docs/delivery/greenfield/reviewer/README.md
- docs/delivery/greenfield/reviewer/review-checklist.md
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orchestrate-phase-deliveryskill under.agents/skills/, including authored evals, validation, packaging guidance, and recovery protocoltrack.jsondependency edgeValidation
pnpm checkTransition
This intentionally supersedes the custom candidate sealer as a required delivery or review prerequisite. Historical seal evidence remains historical only; ordinary committed-candidate evidence plus continuous independent review and normal hosted CI govern this workflow.
Summary by CodeRabbit
New Features
Documentation
Chores