fix(browser): keep background Chromium profile alive - #308
Merged
Conversation
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent macOS background Cloak Chromium from crashing with
EXC_BREAKPOINT / SIGTRAPafterwebcmd doctorcloses its probe window.The background launcher bypasses Playwright defaults, so
DestroyProfileOnBrowserCloseremained enabled while Webcmd kept a hidden CDP target alive. This disables that feature in the macOS background launch arguments and tests the emitted/usr/bin/openargument.Related issue: None
Type of Change
Checklist
Adapter Notes
Screenshots / Output
npm run build: passedwebcmd doctor: green; Chromium remained alive for 8 seconds after completion; no crash report generated