Skip to content

fix(browser): keep background Chromium profile alive - #308

Merged
ankitranjan7 merged 1 commit into
mainfrom
fix/darwin-background-profile-crash
Aug 14, 2026
Merged

fix(browser): keep background Chromium profile alive#308
ankitranjan7 merged 1 commit into
mainfrom
fix/darwin-background-profile-crash

Conversation

@ankitranjan7

Copy link
Copy Markdown
Contributor

Description

Prevent macOS background Cloak Chromium from crashing with EXC_BREAKPOINT / SIGTRAP after webcmd doctor closes its probe window.

The background launcher bypasses Playwright defaults, so DestroyProfileOnBrowserClose remained enabled while Webcmd kept a hidden CDP target alive. This disables that feature in the macOS background launch arguments and tests the emitted /usr/bin/open argument.

Related issue: None

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📝 Documentation
  • 🔧 Maintenance / refactor

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Adapter Notes

  • I updated an existing adapter command
  • I added a new adapter command
  • I updated the adapter manifest/examples
  • I ran adapter verification

Screenshots / Output

  • Focused regression: 6 passed
  • Full suite: 5,550 passed, 56 skipped
  • npm run build: passed
  • Live macOS webcmd doctor: green; Chromium remained alive for 8 seconds after completion; no crash report generated

@github-actions

Copy link
Copy Markdown
Contributor

🟠 Maintainer review suggested — low confidence

The automated review could not reach a fully supported conclusion.

Limitations

  • The automated review returned an invalid structured result.

This review is advisory and does not block merging.

@ankitranjan7
ankitranjan7 merged commit b87fa87 into main Aug 14, 2026
35 checks passed
@ankitranjan7
ankitranjan7 deleted the fix/darwin-background-profile-crash branch August 14, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant