feat(ci): vouch first-time contributors, and say the rule about understanding - #148
Merged
Conversation
…standing Mirrors the change already merged in cmcp. The vouch check closes a pull request from an account that has not been vouched and comments explaining how to get vouched. The judgement stays human: a maintainer comments /vouch @username, the command workflow appends to the list, and the check only ever reads it. Nothing here scores anybody. The list lives on a dedicated orphan branch, seeded with the accounts that already have a merged pull request here, so nobody who has contributed before gets turned away. The check reads it from that branch rather than from the pull request branch, because an author can edit any file in their own fork. It fails open: an unreadable list is our problem, and silently closing every pull request would be worse than letting one through. It composes with the existing contributor reputation check rather than replacing it. That check is advisory, comments and labels a risk level and closes nothing, so it reads as evidence for the maintainer deciding whether to vouch rather than as a verdict of its own. CONTRIBUTING also gains the rule worth having whether or not the gate ships: use agents, and understand what you submit. If you cannot explain a change with the agent closed, do not open the pull request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uc16CsknaQ9PTLxGj8TXXj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors what is already merged in
cmcp(agentrust-io/cmcp#605).The gate
A pull request from an account not on the vouched list is closed with a comment explaining how to get vouched. The judgement stays human: a maintainer comments
/vouch @username,vouch-command.ymlappends to the list, andvouch-check.ymlonly ever reads it. Nothing here scores anybody.vouchedbranch, never the PR branch, because an author can edit any file in their own fork.pull_request_targetwith a write-capable token.It composes with the reputation check rather than replacing it
The existing contributor reputation check is advisory: it comments and labels a risk level and closes nothing. So it reads as evidence for the maintainer deciding whether to vouch, rather than as a verdict of its own. A score acting as a verdict is the thing that failed review elsewhere; a score informing a person is a different mechanism.
And the half that costs nothing
CONTRIBUTING.mdgains the understanding rule: use agents, a lot of this was built with them, and if you cannot explain your change with the agent closed, do not open the PR. That is going to every repository including the spec ones, gate or no gate.🤖 Generated with Claude Code
https://claude.ai/code/session_01Uc16CsknaQ9PTLxGj8TXXj