feat(commands): review, credentials, goals, log + minor fixes [v0.3.0 — 4/7]#734
feat(commands): review, credentials, goals, log + minor fixes [v0.3.0 — 4/7]#734kokevidaurre merged 4 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several new CLI commands—goals, credentials, review, and log—and refactors the run --org command to use a wave-based parallel execution model with improved quota detection and resume support. The core architecture has transitioned to a Plan-Execute-Review-Verify workflow, with prompts and protocols externalized to markdown files and enhanced transcript compaction to manage context limits. Additionally, the PR implements GCP credential management for squads and improves directory discovery for git worktrees. Review feedback highlights an opportunity to make a hardcoded username configurable, suggests replacing an unnecessary dynamic import with a static one, and identifies redundant logic in the credentials command.
…fixes New commands: - credentials.ts: per-squad GCP service account management - goals.ts: goals dashboard with status tracking - log.ts: run history with timestamps, duration, status - review.ts: post-cycle evaluation dashboard Fixes applied: - Added CLI_LOG telemetry event - Removed unused imports (writeFileSync, formatRelativeTime) - Removed unused variables (blockedStr, achievedStr) - Fixed hardcoded org name in review.ts issue URL resolution Co-Authored-By: Claude <noreply@anthropic.com>
8969b90 to
81bbc72
Compare
- Use static renameSync import instead of dynamic import('fs')
- Remove redundant --all handling (dedicated create-all command exists)
Co-Authored-By: Claude <noreply@anthropic.com>
… SQUAD.md credentials.ts had our internal squad names and GCP roles hardcoded. Now fully agnostic: - Permissions read from SQUAD.md `credentials.gcp.roles/apis` fields - Squads discovered dynamically from squads directory - No hardcoded squad names, org names, or internal structure - Helpful error message shows users how to configure their SQUAD.md - create-all discovers squads with GCP config automatically Co-Authored-By: Claude <noreply@anthropic.com>
Extracted parseGcpCredentials() as pure function for testability. Tests cover: inline YAML, quoted values, multiple APIs, missing config, empty content, roles without apis, mixed SQUAD.md content. All 8 pass. Co-Authored-By: Claude <noreply@anthropic.com>
Summary — PR 4 of 7 for v0.3.0 release
4 new commands + minor fixes to existing commands.
Changes (10 files)
New commands:
Updated:
Merge order
Depends on #731, #732, #733. Merge fourth:
Test plan
npm run buildpassesReorganized from 219-commit develop branch for proper review.