Skip to content

feat(commands): review, credentials, goals, log + minor fixes [v0.3.0 — 4/7]#734

Merged
kokevidaurre merged 4 commits intodevelopfrom
v030/new-commands
Apr 14, 2026
Merged

feat(commands): review, credentials, goals, log + minor fixes [v0.3.0 — 4/7]#734
kokevidaurre merged 4 commits intodevelopfrom
v030/new-commands

Conversation

@kokevidaurre
Copy link
Copy Markdown
Contributor

Summary — PR 4 of 7 for v0.3.0 release

4 new commands + minor fixes to existing commands.

Changes (10 files)

New commands:

  • credentials.ts: per-squad GCP service account management
  • goals.ts: goals dashboard with status tracking
  • log.ts: run history with timestamps, duration, status
  • review.ts: post-cycle evaluation dashboard for founder/COO

Updated:

  • cli.ts: register new commands
  • catalog.ts, context.ts, observability.ts, release-check.ts, services.ts: minor fixes

Merge order

Depends on #731, #732, #733. Merge fourth:

  1. ✅ core-refactor (refactor(core): run engine decomposition + context helpers [v0.3.0 — 1/7] #731)
  2. ✅ run-engine (feat(run): workflow rewrite — smart skip, org cycle, wave execution [v0.3.0 — 2/7] #732)
  3. ✅ conversation (feat(conversation): agents talk + use tools [v0.3.0 — 3/7] #733)
  4. → new-commands (this PR)
  5. init-ux
  6. security-guardrails
  7. tests-docs

Test plan

  • npm run build passes
  • Review each new command for UX and correctness
  • Review credentials command for security

Reorganized from 219-commit develop branch for proper review.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new CLI commands—goals, credentials, review, and log—and refactors the run --org command to use a wave-based parallel execution model with improved quota detection and resume support. The core architecture has transitioned to a Plan-Execute-Review-Verify workflow, with prompts and protocols externalized to markdown files and enhanced transcript compaction to manage context limits. Additionally, the PR implements GCP credential management for squads and improves directory discovery for git worktrees. Review feedback highlights an opportunity to make a hardcoded username configurable, suggests replacing an unnecessary dynamic import with a static one, and identifies redundant logic in the credentials command.

Comment thread src/commands/credentials.ts
Comment thread src/commands/credentials.ts Outdated
Comment thread src/commands/credentials.ts Outdated
…fixes

New commands:
- credentials.ts: per-squad GCP service account management
- goals.ts: goals dashboard with status tracking
- log.ts: run history with timestamps, duration, status
- review.ts: post-cycle evaluation dashboard

Fixes applied:
- Added CLI_LOG telemetry event
- Removed unused imports (writeFileSync, formatRelativeTime)
- Removed unused variables (blockedStr, achievedStr)
- Fixed hardcoded org name in review.ts issue URL resolution

Co-Authored-By: Claude <noreply@anthropic.com>
Jorge Vidaurre and others added 3 commits April 13, 2026 20:00
- Use static renameSync import instead of dynamic import('fs')
- Remove redundant --all handling (dedicated create-all command exists)

Co-Authored-By: Claude <noreply@anthropic.com>
… SQUAD.md

credentials.ts had our internal squad names and GCP roles hardcoded.
Now fully agnostic:

- Permissions read from SQUAD.md `credentials.gcp.roles/apis` fields
- Squads discovered dynamically from squads directory
- No hardcoded squad names, org names, or internal structure
- Helpful error message shows users how to configure their SQUAD.md
- create-all discovers squads with GCP config automatically

Co-Authored-By: Claude <noreply@anthropic.com>
Extracted parseGcpCredentials() as pure function for testability.
Tests cover: inline YAML, quoted values, multiple APIs, missing config,
empty content, roles without apis, mixed SQUAD.md content.

All 8 pass.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions bot added the tests label Apr 14, 2026
@kokevidaurre kokevidaurre merged commit f895b3c into develop Apr 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant