Skip to content

test+docs: coverage + tier 2 docs + version bump 0.3.0 [v0.3.0 — 7/7]#737

Merged
kokevidaurre merged 3 commits intodevelopfrom
v030/tests-docs
Apr 14, 2026
Merged

test+docs: coverage + tier 2 docs + version bump 0.3.0 [v0.3.0 — 7/7]#737
kokevidaurre merged 3 commits intodevelopfrom
v030/tests-docs

Conversation

@kokevidaurre
Copy link
Copy Markdown
Contributor

Summary — PR 7 of 7 for v0.3.0 release

Test coverage, documentation, and version bump. Final PR before release.

Changes (10 files)

Tests added:

  • catalog.test.ts, dashboard.test.ts, services.test.ts
  • guardrail.test.ts, init.test.ts, workflow.test.ts, telemetry.test.ts
  • first-run.e2e.test.ts (updated for demo scaffold)

Docs:

  • docs/tier2.md: Tier 2 architecture documentation

Version:

  • package.json: bump to 0.3.0

Merge order

Depends on ALL previous PRs. Merge LAST:

  1. ✅ core-refactor (refactor(core): run engine decomposition + context helpers [v0.3.0 — 1/7] #731)
  2. ✅ run-engine (feat(run): workflow rewrite — smart skip, org cycle, wave execution [v0.3.0 — 2/7] #732)
  3. ✅ conversation (feat(conversation): agents talk + use tools [v0.3.0 — 3/7] #733)
  4. ✅ new-commands (feat(commands): review, credentials, goals, log + minor fixes [v0.3.0 — 4/7] #734)
  5. ✅ init-ux (feat(init): demo agent scaffold, what's next guidance [v0.3.0 — 5/7] #735)
  6. ✅ security-guardrails (feat(security): PreToolUse guardrail hooks for agent sessions [v0.3.0 — 6/7] #736)
  7. → tests-docs (this PR)

After merging all 7: develop = v0.3.0 release candidate → create develop→main PR.

Test plan

  • npm run build passes
  • Run full test suite after all PRs merged
  • Verify version is 0.3.0

Reorganized from 219-commit develop branch for proper review.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades squads-cli to version 0.3.0, refactoring squad workflows into a Plan-Execute-Review-Verify model and adding commands for logging, goals, reviews, and credentials. Key enhancements include wave-based parallel execution, resume support, and destructive command guardrails. Feedback identifies critical ESM compatibility issues with require, redundant imports, and a resource leak from an uncleared timeout. Suggestions were also made to improve the portability of blocker detection and the consistency of date handling for CLI skip logic.

Comment thread src/lib/cognition.ts Outdated
Comment thread src/lib/cognition.ts Outdated
Comment thread src/commands/credentials.ts Outdated
Comment thread src/commands/credentials.ts
Comment thread src/commands/review.ts
Comment thread src/lib/workflow.ts Outdated
Comment thread src/commands/run.ts
Tests added (213 new tests):
- catalog.test.ts: catalog command tests
- dashboard.test.ts: dashboard engine, renderers, loader tests
- services.test.ts: services command tests
- first-run.e2e.test.ts: updated for demo squad scaffold
- guardrail.test.ts: guardrail hook tests
- init.test.ts: expanded init command tests
- telemetry.test.ts: telemetry event tests

Docs:
- docs/tier2.md: Tier 2 architecture documentation

Version:
- package.json: bump to 0.3.0

Note: cli.test.ts failures are pre-existing on develop (not introduced by this PR).

Co-Authored-By: Claude <noreply@anthropic.com>
Jorge Vidaurre and others added 2 commits April 13, 2026 23:12
Hardcoded our repo structure, ports, service names. Belongs in
private engineering repo, not the public CLI.

Co-Authored-By: Claude <noreply@anthropic.com>
Before: 2,299 lines mocking fs, squad-parser, child_process, etc.
Testing mocks, not the product. False confidence.

After: 465 lines testing real files on real filesystem.
- catalog: real IDP directory with YAML files
- dashboard: zero mocks, real data structures into renderers
- services: real docker-compose.yml in temp dir
- init: real temp directory, verify actual files created

39 tests, all passing. 80% less code, 100% more real coverage.

Co-Authored-By: Claude <noreply@anthropic.com>
@kokevidaurre kokevidaurre merged commit f83475b into develop Apr 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant