test+docs: coverage + tier 2 docs + version bump 0.3.0 [v0.3.0 — 7/7]#737
Merged
kokevidaurre merged 3 commits intodevelopfrom Apr 14, 2026
Merged
test+docs: coverage + tier 2 docs + version bump 0.3.0 [v0.3.0 — 7/7]#737kokevidaurre merged 3 commits intodevelopfrom
kokevidaurre merged 3 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades squads-cli to version 0.3.0, refactoring squad workflows into a Plan-Execute-Review-Verify model and adding commands for logging, goals, reviews, and credentials. Key enhancements include wave-based parallel execution, resume support, and destructive command guardrails. Feedback identifies critical ESM compatibility issues with require, redundant imports, and a resource leak from an uncleared timeout. Suggestions were also made to improve the portability of blocker detection and the consistency of date handling for CLI skip logic.
d281672 to
8b67e04
Compare
Tests added (213 new tests): - catalog.test.ts: catalog command tests - dashboard.test.ts: dashboard engine, renderers, loader tests - services.test.ts: services command tests - first-run.e2e.test.ts: updated for demo squad scaffold - guardrail.test.ts: guardrail hook tests - init.test.ts: expanded init command tests - telemetry.test.ts: telemetry event tests Docs: - docs/tier2.md: Tier 2 architecture documentation Version: - package.json: bump to 0.3.0 Note: cli.test.ts failures are pre-existing on develop (not introduced by this PR). Co-Authored-By: Claude <noreply@anthropic.com>
8b67e04 to
a0ff163
Compare
Hardcoded our repo structure, ports, service names. Belongs in private engineering repo, not the public CLI. Co-Authored-By: Claude <noreply@anthropic.com>
Before: 2,299 lines mocking fs, squad-parser, child_process, etc. Testing mocks, not the product. False confidence. After: 465 lines testing real files on real filesystem. - catalog: real IDP directory with YAML files - dashboard: zero mocks, real data structures into renderers - services: real docker-compose.yml in temp dir - init: real temp directory, verify actual files created 39 tests, all passing. 80% less code, 100% more real coverage. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary — PR 7 of 7 for v0.3.0 release
Test coverage, documentation, and version bump. Final PR before release.
Changes (10 files)
Tests added:
Docs:
Version:
Merge order
Depends on ALL previous PRs. Merge LAST:
After merging all 7: develop = v0.3.0 release candidate → create develop→main PR.
Test plan
npm run buildpassesReorganized from 219-commit develop branch for proper review.