publish: resumable by workflow_dispatch on a tag - #105
Merged
Conversation
A publish that dies after the npm step (a transient Sigstore POST failure on v0.5.3 did exactly that) leaves the version on npm with no signed binaries, no release and no tap update, and a re-run of the tag's job fails at npm publish before reaching them. The workflow now takes a tag by dispatch, skips the npm step when that version is already published, uploads assets to an existing release instead of failing to create it, and reads the tag from one variable in every step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the publish workflow resumable. The v0.5.3 publish died on a transient Sigstore POST while signing the third binary, after
npm publishhad already succeeded, which left 0.5.3 on npm with no signed binaries, no GitHub Release and no Homebrew tap update, and a re-run of the tag's job would fail atnpm publishbefore reaching any of them.Three changes, all in
.github/workflows/publish.yml: aworkflow_dispatchtrigger taking the tag (checkout at that ref); the npm step skips when that exact version is already on the registry; the release step uploads assets to an existing release instead of failing to create it. Every step reads the tag from oneRELEASE_TAGvariable so the push and dispatch paths are the same code. Dispatchingv0.5.3after this merges finishes that release.Worked with Varun.
Type of change
Public API
none
Test plan
Workflow-only change; no unit surface. Verification is the dispatched run for v0.5.3 after merge: the npm step reports the skip, the five binaries sign, the release lands with ten assets, and the tap's formula moves to 0.5.3. The CI job on this PR only lints the workflow.
Checklist