docs(changelog): a revoked integration grant stays revoked - #177
Merged
Conversation
Pairs with bea73a723 — a stale approval gate resolved after an explicit revoke no longer resurrects the grant it belonged to. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`_lint-openapi-drift` compares agentsfleet's live main openapi.json
against the operations docs.json references, and M136's connector work
landed upstream without its two entries here:
DELETE /v1/workspaces/{workspace_id}/connectors/{provider}
POST /v1/connectors/{provider}/callback
Both are public and documented upstream -- a provider disconnect, and
the dashboard's callback completion. Placed beside their same-path
siblings, matching how the Secrets group orders its verbs.
Unrelated to this branch's changelog entry; it fails every docs PR
opened after that upstream merge, this one included.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentsfleet@bea73a723(branchfeat/m164-002-coverage-floors) — a stale approval gate resolved after an explicit revoke no longer resurrects the revoked grant.Test plan
make lint's documentation checks pass (22/22). The separate_lint-openapi-driftfailure on this branch (DELETE /v1/workspaces/{workspace_id}/connectors/{provider},POST /v1/connectors/{provider}/callbackmissing fromdocs.json) pre-exists onorigin/main— confirmed via a clean stash-and-relint — and is unrelated to this change; out of scope here.🤖 Generated with Claude Code
Greptile Summary
This PR documents the fix preventing stale approval gates from restoring revoked integration grants and updates the API navigation metadata to include the connector deletion and callback endpoints.
DELETEand callbackPOSToperations todocs.json.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (2): Last reviewed commit: "docs(api): list the two connector operat..." | Re-trigger Greptile
Context used: