Skip to content

Manure methods 1.1.0#24

Open
crakerb-ship-it wants to merge 12 commits intomainfrom
Manure-Methods--1.1.0
Open

Manure methods 1.1.0#24
crakerb-ship-it wants to merge 12 commits intomainfrom
Manure-Methods--1.1.0

Conversation

@crakerb-ship-it
Copy link
Copy Markdown
Contributor

Pull Request: Modus Manure Method List v1.0.1 → v1.1.0

Summary

This release updates the Modus Manure Method list from v1.0.1 to v1.1.0. The primary changes are a systematic harmonization of reporting units (mg/kg and g/kg → %), alignment of method names and reagent notation with soil and plant tissue list conventions, completion of the TKN→TN analyte code rationalization chain, resolution of duplicate entries, and addition of 6 new methods. All 132 published v1.0.1 codes are preserved.

Row counts:

Status v1.0.1 v1.1.0
VALID 87 47
CANDIDATE 43
SUPERSEDED 13 50
RETIRED 31 34
INVALID 1 1
Total 132 175

The reduction in VALID rows reflects UoM harmonization — 35 active methods were superseded and replaced by CANDIDATE codes reporting in percent. The 3 additional RETIRED rows are codes introduced and immediately retired as part of the duplicate/chain resolution described below.

The published code suppression lookup file (Modus2 Manure Code Supersession.xlsx) has been updated in tandem — see Suppression File Updates below.


Changes by Category

1. Reporting Unit Harmonization — mg/kg and g/kg → % (major change)

All active methods previously reporting in mg/kg have been superseded by CANDIDATE replacements using percent (%) as the reporting unit, with UoM Code prcnt, QUDT Code PERCENT, and QUDT URI http://qudt.org/vocab/unit/PERCENT. One additional method (water-extractable phosphorus) was converted from g/kg to %.

35 VALID rows superseded; 35 CANDIDATE replacement rows added.

Affected analytes (14 total): arsenic, boron (×3 methods), cadmium, chloride (×6 across three extraction variants — acetic acid potentiometric, acetic acid coulometry, calcium nitrate spectrophotometric), cobalt, chromium (×2), copper (×4), iron (×4), lead, manganese (×4), molybdenum, nickel, selenium, water-extractable phosphorus, zinc (×3).

Each superseded code maps to its CANDIDATE replacement with Change Comment: "Mass-per-mass/ppm harmonization to percent."

2. TKN → TN Analyte Code Rationalization — Chain Completion

A prior release (v1.0.x) superseded TKN_001–005 into TKN_006–008 and TN_001–002, correcting the analyte code from TKN to TN (Kjeldahl is the extraction method, not a property of the analyte) and rationalizing duplicate instrument variants.

This release completes the chain by superseding TKN_006–008 into TN_003–005:

Old Code New Code Instrument
TKN_006 TN_003 Distillation/Titration
TKN_007 TN_004 Spectrophotometric
TKN_008 TN_005 Diffusion Conductivity

The full V1→current resolution chain is now: V1 TKN code → TKN_001–005 → TKN_006–008 → TN_003–005 (CANDIDATE).

3. New Methods Added

6 new CANDIDATE methods added:

Code Analyte Common Method Name Instrument Submitted By
NH4N_007 ammonium-nitrogen Potassium Chloride Distillation
BA_001 barium Microwave-Assisted Acid Digestion, Open Vessel ICP-OES
BA_002 barium Open Vessel Hot Plate Digestion ICP-OES
MG_005 magnesium Muffle Furnace Dry Ashing ICP-OES
MN_009 manganese Muffle Furnace Dry Ashing ICP-OES
TN_006 nitrogen, total Hicks Nitrogen TNb Redox and Chemiluminescence NCDA&CS

TN_006 (Hicks) is cited to Standard Methods for the Examination of Water and Wastewater, 24th ed., Method 4500-N (APHA). Reporting unit harmonized from ppm to % per list convention. Code pending formal Agrisemantics assignment.

4. Method Name and Reagent Notation Alignment

Method names and reagent notation were harmonized across the list to align with the conventions established in the soil and plant tissue lists. These were in-place edits on existing rows (no status change required, as they are normalizations rather than method changes).

Microwave digestion naming: Microwave Digestion Open VesselMicrowave-Assisted Acid Digestion, Open Vessel and Microwave Digestion Closed VesselMicrowave-Assisted Acid Digestion, Closed Vessel. Applied to all affected rows including both VALID and SUPERSEDED entries.

Reagent abbreviations: Spelled-out reagent names standardized to chemical notation — e.g., Nitric acid, hydrochloric acid, peroxideHNO3, HCl, H2O2; Nitric acidHNO3; Sulfuric Acid / CatalystH2SO4 / Catalyst. This matches the notation applied in the soil list.

These changes appear in the Change Comment field of affected rows alongside any other changes made to those rows (UoM harmonization, duplicate resolution, etc.).

5. Duplicate and Error Resolution

TN duplicate removal: TN_006–010 were identified as exact content duplicates of TN_001–005 (same analyte, method, and instrument across all fields) and removed. This reduced the VALID count and corrected the code sequence before new methods were added.

Sulfur duplicate resolution: S_004 was an invalid duplicate of S_001 (same method, extraction, and instrument). S_005 was a third duplicate with INVALID status. S_001 and S_004 remain as SUPERSEDED records pointing to S_002 (the canonical VALID open-vessel sulfur method). S_005 remains INVALID.

S_004 v1Code error: S_004 incorrectly carried v1Code = M-ZN.15.08 (a zinc v1 code). This mapping was cleared; M-ZN.15.08 is correctly associated with ZN_003.

6. Timestamp Standardization

All Row Added Date and Row Changed Date values updated to ISO 8601 UTC noon format (YYYY-MM-DDT12:00:00Z).

7. QUDT URI and UoM Code Columns Added

UoM Code, QUDT Code, and QUDT URI columns added across all rows. Values sourced from the QUDT ontology (http://qudt.org/vocab/unit/).


Suppression File Updates

Modus2 Manure Code Supersession.xlsx updated from 92 entries to 129 entries.

Prior state: 79 V1→V2 mappings, 13 V2→V2 mappings (P series, TKN_001–005, S_001/S_004 from prior releases).

Net additions — 37 new V2→V2 entries:

  • 34 UoM-harmonization pairs: Each VALID mg/kg code superseded in this release maps to its CANDIDATE % replacement. Covers all 14 affected analytes (33 mg/kg pairs + 1 g/kg pair for water-extractable phosphorus).
  • 3 TKN chain-completion entries: TKN_006 → TN_003, TKN_007 → TN_004, TKN_008 → TN_005 (completing the multi-hop V1 TKN resolution chain).

Historical corrections applied to existing entries:

  • M-ZN.15.08 → S_004 corrected to M-ZN.15.08 → ZN_003: The v1 zinc code was incorrectly mapped to a sulfur V2 code. Root cause was the erroneous v1Code assignment on S_004 (resolved above).
  • S_001 → S_005 and S_004 → S_005 corrected to → S_002: S_005 is INVALID and was an incorrect supersession target. Both codes now correctly resolve to S_002, the canonical VALID open-vessel sulfur method.

Suppression chain notes:

  • V1 TKN codes now follow a 3-hop chain to current: V1 → TKN_001–005 → TKN_006–008 → TN_003–005. Consumers following the chain will resolve correctly.
  • TN_006 (Hicks) is a new method with no prior V1 code; no suppression entry is required.

Open Items

  • All CANDIDATE rows (43) have V2 codes assigned except TN_006 (Hicks), which is pending formal Agrisemantics assignment.
  • Citation links are missing for the majority of rows and will be updated in a future release.
  • Several UoM's do not exist in QUDT, these will be updated from "Needs QUDT Discussion" to new UoM code once PR's are complete with QUDT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross matrix description alignment Align to QUDT UoM codes following ADAPT UoM consistency

1 participant