fix: update GoogleSearch tool parameters#2430
fix: update GoogleSearch tool parameters#2430Shivam909058 wants to merge 1 commit intoagno-agi:mainfrom
Conversation
- Changed num_results parameter to num to match googlesearch-python API - Removed advanced parameter as it's no longer supported - Updated documentation and type hints - Added better error handling
|
fixed the isssue " #2429" |
|
@Shivam909058 thanks for getting this to our attention. Although the workaround seems fine but i think it'll be better long term to directly implement the suggested solution you just mentioned and support the changed api params directly via the SDK. |
| from agno.storage.sqlite import SqliteStorage | ||
| from agno.tools.googlesearch import GoogleSearchTools | ||
| from agno.storage.workflow.sqlite import SqliteWorkflowStorage | ||
| from agno.tools.googlesearch import GoogleSearch |
There was a problem hiding this comment.
I think this is incorrect
There was a problem hiding this comment.
Yes, we've merged agent and workflows storage right
There was a problem hiding this comment.
Yes and the tool name as well
|
Please provide a brief description what to change for merging So please tell me |
So your import fixes are incorrect as mentioned. Thanks for the contribution! |
Description
Fixes # (issue)
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).
Description
Fixed compatibility issues with googlesearch-python library in the GoogleSearch tool.
Changes
num_resultsparameter tonumto match current googlesearch-python APIadvancedparameterTesting
Tested with:
Related Issues
Fixes #[issue-number] (if there is one)
Dependencies
Breaking Changes
advancedparameternum_resultstonumin method signature