Feat/cartesia integration fixes by Mustafa-Esoofally · Pull Request #2496 · agno-agi/agno

Mustafa-Esoofally · 2025-03-22T00:02:56Z

Description

Summary of changes: Describe the key changes in this PR and their purpose.
Related issues: Mention if this PR fixes or is connected to any issues.
Motivation and context: Explain the reason for the changes and the problem they solve.
Environment or dependencies: Specify any changes in dependencies or environment configurations required for this update.
Impact on metrics: (If applicable) Describe changes in any metrics or performance benchmarks.

Fixes # (issue)

Type of change

Please check the options that are relevant:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Model update (Addition or modification of models)
Other (please describe):

Checklist

Adherence to standards: Code complies with Agno’s style guidelines and best practices.
Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
Self-review completed: A thorough review has been performed by the contributor(s).
Documentation: Docstrings and comments have been added or updated for any complex logic.
Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).

manthanguptaa · 2025-03-22T02:43:27Z

cookbook/tools/cartesia_tools.py

+from dotenv import load_dotenv
+
+# Get Cartesia API key from environment or use a default for demo
+cartesia_api_key = os.environ.get("CARTESIA_API_KEY", "sk_car_4y7Jz9aKsF6VeLpBKzKwJ")


Your API key will get leaked

Please remove!

manthanguptaa · 2025-03-22T02:44:12Z

cookbook/tools/cartesia_tools.py

+Example script for using the Cartesia toolkit with an Agno agent for text-to-speech generation.
+"""



We usually add setup steps at the top for that tool

manthanguptaa · 2025-03-22T02:45:34Z

libs/agno/agno/tools/cartesia.py

        self.client = Cartesia(api_key=self.api_key)

+        # Set default output directory for audio files
+        self.output_dir = os.path.join(os.getcwd(), "cartesia_output")


tmp/cartesia

ysolanky · 2025-03-24T22:09:39Z

libs/agno/agno/tools/cartesia.py

        self.client = Cartesia(api_key=self.api_key)

+        # Set default output directory for audio files
+        self.output_dir = os.path.join(os.getcwd(), "tmp/cartesia")


Please use from pathlib import Path instead of os.path

made the change

ysolanky · 2025-03-24T22:12:05Z

cookbook/tools/cartesia_tools.py

- Set the following environment variable:
-    export CARTESIA_API_KEY="your_api_key"
+import os
+import sys


Do we need to import these two libraries entirely?

made the change

ysolanky · 2025-03-24T22:12:55Z

cookbook/tools/cartesia_tools.py

+# )
+
+# Example 5: Stream TTS - Generate speech with streaming capabilities
+agent.print_response(


Please comment out the first example, this looks odd

ysolanky · 2025-03-24T22:13:12Z

libs/agno/agno/tools/cartesia.py

 import json
 from os import getenv
 from typing import Dict, List, Optional, Any
+import os


Suggested change

import os

dirkbrnd · 2025-03-27T09:34:14Z

cookbook/tools/cartesia_tools.py

+cartesia_api_key = os.environ.get("CARTESIA_API_KEY")
+load_dotenv()


Don't need either of these

dirkbrnd · 2025-03-27T09:36:17Z

libs/agno/agno/tools/cartesia.py

+        output_format_bit_rate: int = 128000,
+        output_format_encoding: str = None,
+        output_path: str = None,
+        **kwargs,


We can't have kwargs. How would the model know what to pass?

dirkbrnd · 2025-03-27T09:38:01Z

libs/agno/agno/tools/cartesia.py

+        output_format_sample_rate: int = 44100,
+        output_format_bit_rate: int = 128000,
+        output_format_encoding: str = None,
+        **kwargs,


dirkbrnd · 2025-03-27T09:38:24Z

libs/agno/agno/tools/cartesia.py

+            logger.error(f"Error saving audio data: {e}")
+            return json.dumps({"error": str(e)})
+
+    def text_to_speech_stream(


What is the difference with this function? It still just dumps everything?

Cartesia basically has 3 different text-to-speech options: https://docs.cartesia.ai/2024-06-10/api-reference/tts/bytes. I have added all of them. We might need them later when we build advanced agents / apps

Mustafa-Esoofally added 3 commits March 21, 2025 18:58

Cartesia tts fixes

ebb1c6a

cartesia fixes

c2d000c

Cartesia bug fixes

4640722

Mustafa-Esoofally requested a review from a team as a code owner March 22, 2025 00:02

deleted unused file

b62d304

Mustafa-Esoofally mentioned this pull request Mar 22, 2025

Add cartesia tool #2412

Merged

12 tasks

manthanguptaa reviewed Mar 22, 2025

View reviewed changes

add installation steps and fix output directory

f02e817

ysolanky reviewed Mar 24, 2025

View reviewed changes

Formatting and basic changes

c474ed7

dirkbrnd reviewed Mar 27, 2025

View reviewed changes

Update

48ab60f

dirkbrnd reviewed Mar 27, 2025

View reviewed changes

Cartesia stream method fixes and general PR comments

d46f707

dirkbrnd approved these changes Apr 8, 2025

View reviewed changes

dirkbrnd merged commit b9fecec into agno-agi:feat/cartesia-integration Apr 8, 2025

		Example script for using the Cartesia toolkit with an Agno agent for text-to-speech generation.
		"""

		cartesia_api_key = os.environ.get("CARTESIA_API_KEY")
		load_dotenv()

Conversation

Mustafa-Esoofally commented Mar 22, 2025

Description

Type of change

Checklist

Additional Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments