fix(client): populate Signature field correctly for key-based signatures#1710
Merged
Conversation
ramizpolic
approved these changes
Jun 26, 2026
2 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
paralta
force-pushed
the
fix/key-signing-verification
branch
from
June 26, 2026 14:43
79dbe47 to
c0ae6c1
Compare
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
paralta
force-pushed
the
fix/key-signing-verification
branch
from
June 26, 2026 14:53
c0ae6c1 to
9fcfb6c
Compare
paralta
marked this pull request as ready for review
June 26, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #1609 added
SignatureandContentTypefields toPerSignatureResult, it populatedSignatureasbase64(sig.GetContentBundle()). For key-based signatures,ContentBundleis always empty (it only carries the Sigstore bundle for OIDC), so the reconciler was writing an emptySignatureto every key-based row insignature_verifications. ThecatalogSignaturesfunction in the AI catalog explicitly skips any row whereSignature == "", meaning key-signed records silently lost theirtrustManifestin the/v1/agentsresponse.The fix uses
sig.GetSignature()(the actual base64-encoded cryptographic signature) whenContentBundleis empty, falling back tobase64(ContentBundle)only for OIDC signatures where the bundle is the meaningful identifier.Fixes #1620