feat(utils/scanner): add SkillRunner to scan agent skill bundles#1746
Merged
Conversation
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
2 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
SkillRunnerinutils/scanner, the counterpart to the existingMCPRunner, completing security scanning support for records that carry agent skill artifacts. The runner extracts thecore/language_model/agentskillsmodule from a record, unpacks it viaexportfmt.ExtractSkillBundleArchive, and runsskill-scanner scanto produce aScanResultwith per-finding severity.SKILL_SCANNER_LLM_*environment variables are derived automatically from theAZURE_OPENAI_*equivalents so CI doesn't need duplicate config.ExtractSkillBundleArchiveis extended to transparently handle both gzip-tar bundles and plain-textSKILL.mdmanifests via a magic-byte check, eliminating format-detection logic from the scanner itself.utils/go.modswitches from the pinnedapi v1.5.0to a localreplacedirective so the scanner can use the updatedexportfmtpackage before a new tag is cut.trimToSkillJSONlooks for either{or[as the JSON start, unlike the MCP equivalent which only accepts arrays — skill-scanner's single-scan mode emits a top-level object.is_safefield; findings are always surfaced regardless of that verdict so callers have full context.