feat(dir): batch install#1763
Merged
Merged
Conversation
csirmazbendeguz
force-pushed
the
feat/batch-install
branch
from
July 7, 2026 16:00
3ed56ba to
d2275ef
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
csirmazbendeguz
force-pushed
the
feat/batch-install
branch
6 times, most recently
from
July 8, 2026 15:27
bce5c5a to
4826607
Compare
csirmazbendeguz
marked this pull request as ready for review
July 8, 2026 18:33
csirmazbendeguz
force-pushed
the
feat/batch-install
branch
2 times, most recently
from
July 9, 2026 08:55
3c30962 to
a854dc8
Compare
akijakya
reviewed
Jul 9, 2026
akijakya
left a comment
Member
There was a problem hiding this comment.
Overall a solid PR — well-decomposed, the TarIterator refactor reads cleanly, and coverage is good (all changed packages' tests pass locally). Incorporating skill-bundle support into install is the right call. A few things worth addressing before merge — no blockers. Comments inline.
csirmazbendeguz
force-pushed
the
feat/batch-install
branch
7 times, most recently
from
July 9, 2026 13:39
e8781d8 to
851efd2
Compare
Signed-off-by: Bendegúz Csirmaz <csirmazbendeguz@gmail.com>
csirmazbendeguz
force-pushed
the
feat/batch-install
branch
from
July 9, 2026 15:33
851efd2 to
1c45a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If install receives filters, use those filters to fetch the records and install them
If a tool doesn't support skill directories, skip installing
Note, this PR changes the Copilot and Cursor paths so skills are stored in directories instead of markdown files