Skip to content

feat(dir): batch install#1763

Merged
csirmazbendeguz merged 1 commit into
mainfrom
feat/batch-install
Jul 10, 2026
Merged

feat(dir): batch install#1763
csirmazbendeguz merged 1 commit into
mainfrom
feat/batch-install

Conversation

@csirmazbendeguz

@csirmazbendeguz csirmazbendeguz commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

If install receives filters, use those filters to fetch the records and install them

If a tool doesn't support skill directories, skip installing

Note, this PR changes the Copilot and Cursor paths so skills are stored in directories instead of markdown files

@github-actions github-actions Bot added the size/L Denotes a PR that changes 1000-1999 lines label Jul 7, 2026
@csirmazbendeguz
csirmazbendeguz force-pushed the feat/batch-install branch 6 times, most recently from bce5c5a to 4826607 Compare July 8, 2026 15:27
@csirmazbendeguz
csirmazbendeguz marked this pull request as ready for review July 8, 2026 18:33
@csirmazbendeguz
csirmazbendeguz requested a review from a team as a code owner July 8, 2026 18:33
@csirmazbendeguz
csirmazbendeguz force-pushed the feat/batch-install branch 2 times, most recently from 3c30962 to a854dc8 Compare July 9, 2026 08:55

@akijakya akijakya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a solid PR — well-decomposed, the TarIterator refactor reads cleanly, and coverage is good (all changed packages' tests pass locally). Incorporating skill-bundle support into install is the right call. A few things worth addressing before merge — no blockers. Comments inline.

Comment thread api/exportfmt/skill_bundle_extract.go
Comment thread api/exportfmt/skill_bundle_extract.go
Comment thread cli/internal/agentcfg/registry.go
Comment thread cli/cmd/install/flags.go Outdated
Comment thread api/exportfmt/tar_iterator.go
Comment thread api/exportfmt/tar_iterator.go
@csirmazbendeguz
csirmazbendeguz force-pushed the feat/batch-install branch 7 times, most recently from e8781d8 to 851efd2 Compare July 9, 2026 13:39
Signed-off-by: Bendegúz Csirmaz <csirmazbendeguz@gmail.com>

@akijakya akijakya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@csirmazbendeguz
csirmazbendeguz merged commit 4d3de5c into main Jul 10, 2026
32 checks passed
@csirmazbendeguz
csirmazbendeguz deleted the feat/batch-install branch July 10, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 1000-1999 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(cli): batch install for dirctl install (search-filter selection, like pull/export)

2 participants