fix(database): fix GetRecordCIDs failing with PostgreSQL backend#1807
Merged
Conversation
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
paralta
force-pushed
the
fix/search-postgres
branch
from
July 14, 2026 12:36
b18e369 to
781a0bd
Compare
ramizpolic
approved these changes
Jul 14, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetRecordCIDswas queryingSELECT DISTINCT records.record_cidwhileapplyRecordOrderalways appendedORDER BY records.created_at DESC, records.record_cid ASC. PostgreSQL enforces the SQL standard requirement that allORDER BYexpressions appear in theSELECTlist forSELECT DISTINCTqueries (SQLSTATE 42P10), whereas SQLite silently permits it — so the bug only surfaced when running against a real PostgreSQL database.The fix expands the SELECT to include all columns that
applyRecordOrdermay reference (created_at,name,version,schema_version, and usage-metrics expressions when needed). Becauserecord_cidis the primary key, these columns are functionally dependent on it, soDISTINCTstill deduplicates at the record level.Pluckis replaced withFindinto a minimal struct, sincePluckdoes not correctly scan a multi-column result into a string slice.