Skip to content

feat(search): add --schema-version flag to NL search for OASF version scoping#1813

Merged
paralta merged 1 commit into
mainfrom
feat/nl-search-with-oasf-version
Jul 15, 2026
Merged

feat(search): add --schema-version flag to NL search for OASF version scoping#1813
paralta merged 1 commit into
mainfrom
feat/nl-search-with-oasf-version

Conversation

@paralta

@paralta paralta commented Jul 15, 2026

Copy link
Copy Markdown
Member

Records published against OASF 1.0.0 use different skill taxonomy names than records enriched with 1.1.0, so after re-provisioning the extractor with the new schema, natural-language queries generate only 1.1.0 signals and miss older records. This PR adds a --schema-version flag to both dirctl search and dirctl routing search that pins the OASF taxonomy version(s) used during query decomposition, letting operators bridge the gap while older records are re-enriched.

  • Decompose and DecomposeWithMinScore accept variadic sdk.QueryOption arguments and forward them to ext.Extract, keeping existing callers (routing NL search) unchanged with no extra arguments.
  • When --schema-version is omitted the behavior is identical to before — the extractor defaults to ScopeAll and covers every provisioned version.

@github-actions github-actions Bot added the size/S Denotes a PR that changes 50-199 lines label Jul 15, 2026
@paralta
paralta force-pushed the feat/nl-search-with-oasf-version branch from 8d62fe0 to 7275556 Compare July 15, 2026 11:31
@github-actions github-actions Bot added size/XS Denotes a PR that changes 0-49 lines and removed size/S Denotes a PR that changes 50-199 lines labels Jul 15, 2026
@paralta
paralta force-pushed the feat/nl-search-with-oasf-version branch from 7275556 to d0d2764 Compare July 15, 2026 11:38
Signed-off-by: Catarina Paralta <clouropa@cisco.com>
@paralta
paralta force-pushed the feat/nl-search-with-oasf-version branch from d0d2764 to 0f0b863 Compare July 15, 2026 15:28
@paralta
paralta marked this pull request as ready for review July 15, 2026 15:48
@paralta
paralta requested a review from a team as a code owner July 15, 2026 15:48
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/cmd/routing/nlsearch.go 0.0% 4 Missing ⚠️
cli/cmd/search/nlsearch.go 0.0% 4 Missing ⚠️
cli/internal/nlsearch/decompose.go 0.0% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@paralta
paralta merged commit ef1e5ac into main Jul 15, 2026
32 checks passed
@paralta
paralta deleted the feat/nl-search-with-oasf-version branch July 15, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-49 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants