Skip to content

feat(dir): provide oci address in discovery response#1820

Merged
tkircsi merged 3 commits into
mainfrom
feat/provide-oci-address-remote-search-response
Jul 16, 2026
Merged

feat(dir): provide oci address in discovery response#1820
tkircsi merged 3 commits into
mainfrom
feat/provide-oci-address-remote-search-response

Conversation

@tkircsi

@tkircsi tkircsi commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Register an /oci/ multiaddr protocol alongside /dir/ and add a directory_oci_address routing config that is advertised via identify. Routing search now returns both /dir/ and /oci/ prefixed addresses in peer.addrs so consumers can locate a peer's Directory API and OCI registry.

Signed-off-by: Tibor Kircsi <tkircsi@cisco.com>
@tkircsi tkircsi self-assigned this Jul 16, 2026
@tkircsi
tkircsi requested a review from a team as a code owner July 16, 2026 10:54
@tkircsi tkircsi added kind/feature Categorizes issue or PR as related to a new feature. area/dir/server go Pull requests that update go code labels Jul 16, 2026
@github-actions github-actions Bot added the size/S Denotes a PR that changes 50-199 lines label Jul 16, 2026
@ramizpolic ramizpolic added this to the DIR v1.6 milestone Jul 16, 2026
@ramizpolic ramizpolic changed the title feat(dir): provide oci address in response feat(dir): provide oci address in discovery response Jul 16, 2026
Signed-off-by: Tibor Kircsi <tkircsi@cisco.com>
@github-actions github-actions Bot added size/M Denotes a PR that changes 200-999 lines and removed size/S Denotes a PR that changes 50-199 lines labels Jul 16, 2026
…ting results

Signed-off-by: Catarina Paralta <clouropa@cisco.com>
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.49020% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/routing/internal/p2p/host.go 63.9% 8 Missing and 5 partials ⚠️
cli/cmd/sync/sync.go 76.7% 9 Missing and 1 partial ⚠️
server/routing/routing_remote.go 87.5% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@tkircsi
tkircsi merged commit 40130e7 into main Jul 16, 2026
32 checks passed
@tkircsi
tkircsi deleted the feat/provide-oci-address-remote-search-response branch July 16, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dir/server go Pull requests that update go code kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 200-999 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants