⚠️ Sync 066be76ee5d: [release/10.0] Source code updates from dotnet/dotnet (#124136)#84
Closed
github-actions[bot] wants to merge 3 commits into
Closed
⚠️ Sync 066be76ee5d: [release/10.0] Source code updates from dotnet/dotnet (#124136)#84github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
> [!NOTE] > This is a codeflow update. It may contain both source code changes from > [the VMR](https://github.com/dotnet/dotnet) > as well as dependency updates. Learn more [here](https://github.com/dotnet/dotnet/tree/main/docs/Codeflow-PRs.md). This pull request brings the following source code changes [marker]: <> (Begin:74dc5d43-0b13-491a-b063-0f03b26d7664) ## From https://github.com/dotnet/dotnet - **Subscription**: [74dc5d4-0b13-491a-b063-0f03b26d7664](https://maestro.dot.net/subscriptions?search=74dc5d43-0b13-491a-b063-0f03b26d7664) - **Build**: [20260210.24](https://dev.azure.com/dnceng/internal/_build/results?buildId=2900845) ([301313](https://maestro.dot.net/channel/5173/github:dotnet:dotnet/build/301313)) - **Date Produced**: February 11, 2026 9:20:37 AM UTC - **Commit**: [9d0c3bebf9d368ad51c0b9a7b954219d192cd9d6](dotnet/dotnet@9d0c3be) - **Commit Diff**: [52be957...9d0c3be](dotnet/dotnet@52be957...9d0c3be) - **Branch**: [release/10.0.1xx](https://github.com/dotnet/dotnet/tree/release/10.0.1xx) **Updated Dependencies** - From [5.0.0-2.26102.102 to 5.0.0-2.26110.124][6] - Microsoft.CodeAnalysis - Microsoft.CodeAnalysis.Analyzers - Microsoft.CodeAnalysis.CSharp - Microsoft.Net.Compilers.Toolset - From [10.0.104 to 10.0.104][6] - Microsoft.CodeAnalysis.NetAnalyzers - Microsoft.DotNet.ApiCompat.Task - From [10.0.0-beta.26102.102 to 10.0.0-beta.26110.124][6] - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.Build.Tasks.Archives - Microsoft.DotNet.Build.Tasks.Feed - Microsoft.DotNet.Build.Tasks.Installers - Microsoft.DotNet.Build.Tasks.Packaging - Microsoft.DotNet.Build.Tasks.TargetFramework - Microsoft.DotNet.Build.Tasks.Templating - Microsoft.DotNet.Build.Tasks.Workloads - Microsoft.DotNet.CodeAnalysis - Microsoft.DotNet.GenAPI - Microsoft.DotNet.GenFacades - Microsoft.DotNet.Helix.Sdk - Microsoft.DotNet.PackageTesting - Microsoft.DotNet.RemoteExecutor - Microsoft.DotNet.SharedFramework.Sdk - Microsoft.DotNet.XliffTasks - Microsoft.DotNet.XUnitExtensions - From [0.11.5-alpha.26102.102 to 0.11.5-alpha.26110.124][6] - Microsoft.DotNet.Cecil - From [2.9.3-beta.26102.102 to 2.9.3-beta.26110.124][6] - Microsoft.DotNet.XUnitAssert - Microsoft.DotNet.XUnitConsoleRunner - From [10.0.4 to 10.0.4][6] - Microsoft.NET.Sdk.IL - Microsoft.NETCore.App.Ref - Microsoft.NETCore.ILAsm - runtime.native.System.IO.Ports - System.Reflection.Metadata - System.Reflection.MetadataLoadContext - System.Text.Json - From [10.0.104-servicing.26102.102 to 10.0.104-servicing.26110.124][6] - Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport - From [7.0.2-rc.10302 to 7.0.2-rc.11124][6] - NuGet.Frameworks - NuGet.Packaging - NuGet.ProjectModel - NuGet.Versioning - From [2.0.4 to 2.0.4][6] - System.CommandLine - From [10.0.0-alpha.1.26076.1 to 10.0.0-alpha.1.26104.2](dotnet/dotnet@da47e69...b5b1233) - runtime.linux-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.osx-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.osx-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.win-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.win-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport [marker]: <> (End:74dc5d43-0b13-491a-b063-0f03b26d7664) [1]: dotnet/dotnet@52be957...3f106e5 [2]: dotnet/dotnet@52be957...c33eae4 [3]: dotnet/dotnet@52be957...7768201 [4]: dotnet/dotnet@52be957...3628157 [5]: dotnet/dotnet@52be957...a95a98f [6]: dotnet/dotnet@52be957...9d0c3be [marker]: <> (Start:Footer:CodeFlow PR) ## Associated changes in source repos - dotnet/arcade@af17297...58d7536 - dotnet/aspnetcore@693d402...0c6d74d - dotnet/efcore@52a750f...dffd57b - dotnet/runtime@59908f6...9ffba73 - dotnet/sdk@bc6b89b...6b09479 - dotnet/source-build-assets@a70be36...89fffcb - dotnet/sourcelink@bd09f31...2752a5e - dotnet/templating@21a0fc0...8f46f06 - dotnet/windowsdesktop@0ea907c...fbf65c7 - dotnet/winforms@4e97eb7...27d66ad - dotnet/wpf@23f6b49...36f3469 <details> <summary>Diff the source with this PR branch</summary> ```bash darc vmr diff --name-only https://github.com/dotnet/dotnet:9d0c3bebf9d368ad51c0b9a7b954219d192cd9d6..https://github.com/dotnet/runtime:darc-release/10.0-796345f8-10d3-4632-a948-88c3a0c89e57 ``` </details> [marker]: <> (End:Footer:CodeFlow PR) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ease-10.0-066be76ee5d
Deterministic replacement of versioned labels in MODULE.bazel, paket/paket.main.bzl, and BUILD files to match upstream version bumps. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agocke
pushed a commit
that referenced
this pull request
Apr 23, 2026
agocke
added a commit
that referenced
this pull request
May 19, 2026
…#84) > [!NOTE] > This PR description was AI-generated with GitHub Copilot CLI. Extends BXL coverage of `src/tests` from ~57% to ~90% by adding an `il_coreclr_test` macro that reuses the pre-built native ilasm from Core_Root, plus filling in cross-package `srcs` support for `coreclr_test`. ## What's new ### `il_coreclr_test` BXL macro (`src/tests/coreclr_test/il_coreclr_test.dsc`) - Invokes the pre-built `${Core_Root}/ilasm` to assemble `.il` sources into a `.dll` (`-quiet -dll -output=<name>.dll`, optional `-debug` / `-debug=opt` / `-optimize`). - No new native build required — `Defs.CORE_ROOT_ILASM` references the binary already staged in Core_Root. - Reuses the existing `runCoreClrTest` rule so test execution semantics match `coreclr_test` exactly (corerun under `Defs.CORE_ROOT_DIR`, exit-code 100 == pass, 60 s timeout). - Honors bazel `tags = ["manual"]` and `run: false` the same way as `coreclr_test`. ### Refactor in `coreclr_test.dsc` - `emitBuildStamp` / `runCoreClrTest` now take `binary: File` instead of `binary: CSharp.CSharpInfo`, so the IL macro can reuse them with an ilasm output directly. - `supportToolchain`, `bashExe`, `emitBuildStamp`, `runCoreClrTest` switched from file-scoped `const` to `export const` so cross-file references in the same module resolve. ### Port-script extensions (`eng/bxl/port_bazel_tests.py`) - Recognizes `il_coreclr_test` and emits `CoreClr.il_coreclr_test(...)`. - Allows workspace-relative `//pkg:file` labels in `srcs` (BXL's label resolver already handles them). - Verifies every src actually exists in the target tree (bazel-main snapshot is stale relative to upstream). - Drops `//src/tests/Common:TestLibrary` for IL deps — it's already on Core_Root's TPA at runtime. - Preserves `run: false` markers added by `disable_failed_tests.py` across regeneration. ### Disable-script extensions (`eng/bxl/disable_failed_tests.py`) - Recognizes ilasm pip failures (`|| ilasm <name>, /…/BUILD.dsc, …`) in addition to `csc [exe]` failures. - Matches both `coreclr_test` and `il_coreclr_test` blocks when removing/disabling. ## Numbers | | Before | After | |------------------------------|-------:|-------:| | `coreclr_test` targets | 4,082 | 4,310 | | `il_coreclr_test` targets | 0 | 2,405 | | Total ported | 4,082 | 6,715 | | Targets marked `run: false` | 310 | 1,277 | | BXL build pips | 12,233 | 18,761 | | Coverage vs MSBuild (7,490) | ~55% | ~90% | `./bxl.sh` is green. ## Remaining gap (~10%) - Tests with local `:foo` library deps (~100 between coreclr_test and il_coreclr_test). - 37 `coreclr_merged_test` targets (no BXL macro yet). - ~343 srcs referencing files that have been moved/deleted in upstream since the bazel-main snapshot. ## Disabled-tests breakdown The 1,277 `run: false` markers compile but fail at test time. Most are JIT regression / known-bad-IL coverage suites that segfault, stack-overflow, or hit assertions under corerun. Files removed entirely (200 targets across 91 files) are mostly negative IL tests tagged `manual` in bazel that lack entry points. ## Commits - `e8cba74` Port more coreclr_test targets (xpkg srcs, file-existence check) - `19ce7d1` Disable failing new ports: 81 broken-compile removed, 24 runtime failures suppressed - `7049782` Add il_coreclr_test BXL macro using pre-built ilasm - `5246fbf` Port IL tests from bazel-main: +2405 il_coreclr_test targets --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agocke
added a commit
that referenced
this pull request
May 19, 2026
…#84) > [!NOTE] > This PR description was AI-generated with GitHub Copilot CLI. Extends BXL coverage of `src/tests` from ~57% to ~90% by adding an `il_coreclr_test` macro that reuses the pre-built native ilasm from Core_Root, plus filling in cross-package `srcs` support for `coreclr_test`. ## What's new ### `il_coreclr_test` BXL macro (`src/tests/coreclr_test/il_coreclr_test.dsc`) - Invokes the pre-built `${Core_Root}/ilasm` to assemble `.il` sources into a `.dll` (`-quiet -dll -output=<name>.dll`, optional `-debug` / `-debug=opt` / `-optimize`). - No new native build required — `Defs.CORE_ROOT_ILASM` references the binary already staged in Core_Root. - Reuses the existing `runCoreClrTest` rule so test execution semantics match `coreclr_test` exactly (corerun under `Defs.CORE_ROOT_DIR`, exit-code 100 == pass, 60 s timeout). - Honors bazel `tags = ["manual"]` and `run: false` the same way as `coreclr_test`. ### Refactor in `coreclr_test.dsc` - `emitBuildStamp` / `runCoreClrTest` now take `binary: File` instead of `binary: CSharp.CSharpInfo`, so the IL macro can reuse them with an ilasm output directly. - `supportToolchain`, `bashExe`, `emitBuildStamp`, `runCoreClrTest` switched from file-scoped `const` to `export const` so cross-file references in the same module resolve. ### Port-script extensions (`eng/bxl/port_bazel_tests.py`) - Recognizes `il_coreclr_test` and emits `CoreClr.il_coreclr_test(...)`. - Allows workspace-relative `//pkg:file` labels in `srcs` (BXL's label resolver already handles them). - Verifies every src actually exists in the target tree (bazel-main snapshot is stale relative to upstream). - Drops `//src/tests/Common:TestLibrary` for IL deps — it's already on Core_Root's TPA at runtime. - Preserves `run: false` markers added by `disable_failed_tests.py` across regeneration. ### Disable-script extensions (`eng/bxl/disable_failed_tests.py`) - Recognizes ilasm pip failures (`|| ilasm <name>, /…/BUILD.dsc, …`) in addition to `csc [exe]` failures. - Matches both `coreclr_test` and `il_coreclr_test` blocks when removing/disabling. ## Numbers | | Before | After | |------------------------------|-------:|-------:| | `coreclr_test` targets | 4,082 | 4,310 | | `il_coreclr_test` targets | 0 | 2,405 | | Total ported | 4,082 | 6,715 | | Targets marked `run: false` | 310 | 1,277 | | BXL build pips | 12,233 | 18,761 | | Coverage vs MSBuild (7,490) | ~55% | ~90% | `./bxl.sh` is green. ## Remaining gap (~10%) - Tests with local `:foo` library deps (~100 between coreclr_test and il_coreclr_test). - 37 `coreclr_merged_test` targets (no BXL macro yet). - ~343 srcs referencing files that have been moved/deleted in upstream since the bazel-main snapshot. ## Disabled-tests breakdown The 1,277 `run: false` markers compile but fail at test time. Most are JIT regression / known-bad-IL coverage suites that segfault, stack-overflow, or hit assertions under corerun. Files removed entirely (200 targets across 91 files) are mostly negative IL tests tagged `manual` in bazel that lack entry points. ## Commits - `e8cba74` Port more coreclr_test targets (xpkg srcs, file-existence check) - `19ce7d1` Disable failing new ports: 81 broken-compile removed, 24 runtime failures suppressed - `7049782` Add il_coreclr_test BXL macro using pre-built ilasm - `5246fbf` Port IL tests from bazel-main: +2405 il_coreclr_test targets --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream commit:
066be76ee5d— [release/10.0] Source code updates from dotnet/dotnet (dotnet#124136)\nRemaining after this: 18 commit(s)\n\n---\n\n# Sync Report:release/10.0→bazelUpstream commits: 1 | Files changed: 5
Classification:⚠️ build-changes — Bazel-relevant changes detected, review needed
🔧 Modified Build Properties (.props/.targets)
These may affect compilation defines, references, or file includes:
eng/Version.Details.props- <MicrosoftCodeAnalysisPackageVersion>5.0.0-2.26102.102</MicrosoftCodeAnalysisPackageVersion>