add client-go metrics and grafana dashboards#505
Merged
cyriltovena merged 1 commit intoagones-dev:masterfrom Jan 26, 2019
Merged
add client-go metrics and grafana dashboards#505cyriltovena merged 1 commit intoagones-dev:masterfrom
cyriltovena merged 1 commit intoagones-dev:masterfrom
Conversation
Collaborator
|
Build Failed 😱 Build Id: 45210c3a-f0e4-4d0b-b33c-3413e8213000 Build Logs |
cyriltovena
force-pushed
the
features/kubernetes-client-metrics
branch
from
2f2ee4b to
89cbde0
Compare
Collaborator
|
Build Failed 😱 Build Id: be10c59a-241e-4e85-9699-f4f964def331 Build Logs |
markmandel
reviewed
Jan 25, 2019
|
|
||
| - {{< ghlink href="/build/grafana/dashboard-controller-usage.yaml" branch="master" >}}Agones Controller Resource Usage{{< /ghlink >}} displays Agones Controller CPU and memory usage and also some Golang runtime metrics. | ||
|
|
||
| - {{< ghlink href="/build/grafana/dashboard-goclient-requests.yaml" branch="master" >}}Agones Controller go-client requests{{< /ghlink >}} displays Agones Controller Kubernetes API consumption. |
Collaborator
There was a problem hiding this comment.
Should this be hidden until 0.8.0?, Since it's tied to that release?
Collaborator
Author
There was a problem hiding this comment.
sure I'll have a look
Collaborator
There was a problem hiding this comment.
Other than wrapping this in a feature shortcode to hide it until 0.8.0, this LGTM. (Just looking at it again)
markmandel
reviewed
Jan 25, 2019
cyriltovena
force-pushed
the
features/kubernetes-client-metrics
branch
from
89cbde0 to
92f69d8
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 1bdb6f96-1fa6-4b10-8ffc-4a56cf1a65b3 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
added
kind/feature
There's also some refactoring involved within the metrics package to improve flexibility.
cyriltovena
force-pushed
the
features/kubernetes-client-metrics
branch
from
92f69d8 to
4b3128a
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 202c564a-2230-4a90-8917-04ea8aea4fbf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website will exist for the next 30 days: To install this version:
|
Collaborator
|
Hello @Kuqd , my apologize for missing your request. Attaching dashboard example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds metrics integration for client-go and some dashboards that goes along with. I've refactored also our metrics package after having some discussion with @jkowalski last week.
Documentation has been updated with new dashboards.
@jkowalski I think those will be very interesting for you to see our Kubernetes API consumption but also the current status of our workqueues. (Caches is also there but I doubt it will shed more light as for now). Especially when you are load testing our controller.
@aLekSer I would love that you take this for a spin on Stackdriver see if metrics are working well.
This works also helps #144 we should at last add game server allocations and deprecate fleet allocations.
some dashboards screenshots:
Let me know !