[codex] fix desktop update packaging integrity#134
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13fe6ba3d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
13fe6ba to
73331d6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73331d6cee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 150f6c0cbe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Supersedes #96 for ADA-55 after the original PR exhausted Codex review allowance.
Summary
bootstrap.cjs, writepackaged-integrity-manifest.jsonafterapp.asar.unpackedpruning, and verify the unpacked sidecar closure before loadingmain.cjs.127.0.0.1, staging temp paths are canonicalized, and launch-smoke fatal diagnostics retain bounded first-fatal snapshots.Validation
vp check,vp run --cache typecheck, Codex gpt-5.5 autoreview clean.node_modules/.bin/vp checkpassed with existing unrelated unused-import warnings.node_modules/.bin/vp run typecheckpassed.node_modules/.bin/vp test run scripts/desktop-launch-smoke.test.mjs scripts/desktop-after-pack-prune.test.mjs apps/desktop/src/app/PackagedIntegrity.test.ts scripts/build-desktop-artifact.test.ts apps/desktop/src/updates/DesktopUpdates.test.ts apps/desktop/src/updates/updateMachine.test.ts apps/web/src/components/desktopUpdate.logic.test.tspassed: 7 files, 93 tests.Guardrail
The old base has no
apps/desktop/src/app/PackagedIntegrity.tsand still stagesapps/desktop/dist-electron/main.cjsas the packaged entrypoint. The new tests assert manifest generation after pruning and bootstrap entrypoint wiring, so the ADA-55 guardrail fails on the old behavior and passes on this branch.