Skip to content

[codex] fix desktop update packaging integrity#134

Merged
adamfgr merged 9 commits into
mainfrom
wizzo/ada-55-desktop-update-integrity
Jul 8, 2026
Merged

[codex] fix desktop update packaging integrity#134
adamfgr merged 9 commits into
mainfrom
wizzo/ada-55-desktop-update-integrity

Conversation

@wizzoapp

@wizzoapp wizzoapp Bot commented Jul 8, 2026

Copy link
Copy Markdown

Supersedes #96 for ADA-55 after the original PR exhausted Codex review allowance.

Summary

  • Keep main's compact desktop package/prune model and layer the ADA-55 packaged runtime integrity check on top.
  • Stage the packaged desktop entrypoint through bootstrap.cjs, write packaged-integrity-manifest.json after app.asar.unpacked pruning, and verify the unpacked sidecar closure before loading main.cjs.
  • Preserve update-smoke robustness from the old branch: mock update host uses 127.0.0.1, staging temp paths are canonicalized, and launch-smoke fatal diagnostics retain bounded first-fatal snapshots.

Validation

  • Factory pre-commit gate passed on every replayed commit: vp check, vp run --cache typecheck, Codex gpt-5.5 autoreview clean.
  • node_modules/.bin/vp check passed with existing unrelated unused-import warnings.
  • node_modules/.bin/vp run typecheck passed.
  • node_modules/.bin/vp test run scripts/desktop-launch-smoke.test.mjs scripts/desktop-after-pack-prune.test.mjs apps/desktop/src/app/PackagedIntegrity.test.ts scripts/build-desktop-artifact.test.ts apps/desktop/src/updates/DesktopUpdates.test.ts apps/desktop/src/updates/updateMachine.test.ts apps/web/src/components/desktopUpdate.logic.test.ts passed: 7 files, 93 tests.
  • Recycled PR [codex] fix desktop update packaging integrity #96 was green on CI run 28941505453, including Desktop Linux Package Smoke and Desktop Windows Package Smoke.

Guardrail

The old base has no apps/desktop/src/app/PackagedIntegrity.ts and still stages apps/desktop/dist-electron/main.cjs as the packaged entrypoint. The new tests assert manifest generation after pruning and bootstrap entrypoint wiring, so the ADA-55 guardrail fails on the old behavior and passes on this branch.

@wizzoapp wizzoapp Bot marked this pull request as ready for review July 8, 2026 12:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13fe6ba3d0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/desktop/scripts/desktop-update-smoke.mjs
Comment thread scripts/desktop-after-pack-prune.mjs Outdated
@wizzoapp wizzoapp Bot force-pushed the wizzo/ada-55-desktop-update-integrity branch from 13fe6ba to 73331d6 Compare July 8, 2026 13:04
@wizzoapp wizzoapp Bot marked this pull request as draft July 8, 2026 13:04
@wizzoapp wizzoapp Bot marked this pull request as ready for review July 8, 2026 13:04
@wizzoapp wizzoapp Bot marked this pull request as draft July 8, 2026 13:17
@wizzoapp wizzoapp Bot marked this pull request as ready for review July 8, 2026 13:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73331d6cee

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/desktop/scripts/desktop-update-smoke.mjs Outdated
Comment thread apps/desktop/scripts/desktop-update-smoke.mjs
Comment thread scripts/desktop-after-pack-prune.mjs
Comment thread apps/desktop/scripts/desktop-update-smoke.mjs Outdated
Comment thread apps/desktop/scripts/desktop-update-smoke.mjs
@wizzoapp wizzoapp Bot marked this pull request as draft July 8, 2026 13:59
@wizzoapp wizzoapp Bot marked this pull request as ready for review July 8, 2026 13:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 150f6c0cbe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/desktop/scripts/desktop-update-smoke.mjs
Comment thread apps/desktop/scripts/desktop-update-smoke.mjs
Comment thread apps/desktop/scripts/desktop-update-smoke.mjs
@wizzoapp wizzoapp Bot marked this pull request as draft July 8, 2026 14:35
@wizzoapp wizzoapp Bot marked this pull request as ready for review July 8, 2026 14:35

@adamfgr adamfgr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by wizzo-approve: all policy conditions verified against HEAD fc26cdd.

@adamfgr adamfgr enabled auto-merge July 8, 2026 14:48
@adamfgr adamfgr added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit d5d723c Jul 8, 2026
31 checks passed
@adamfgr adamfgr deleted the wizzo/ada-55-desktop-update-integrity branch July 8, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant