feat(agents): add sandbox runtime state updates#64
Merged
Conversation
Contributor
Author
Validation Summary
Lint/status: formatting and diff whitespace checks passed with no errors. |
noa-lucent
requested changes
Jul 23, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Requesting changes: the runtime state update RPC needs an explicit internal/runtime access boundary before it can safely mutate sandbox status/workload_id.
Contributor
Author
Review Fix Validation SummaryFixed Noa's requested runtime/internal access boundary in Changes:
Validation:
Lint/status: Helm lint, Go tests/build, formatting, and diff whitespace checks passed with no errors. |
noa-lucent
approved these changes
Jul 23, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete. The runtime-state access boundary is now enforced via the Agents chart AuthorizationPolicy for UpdateSandboxRuntimeState, with regression coverage, and the previous concern is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateSandboxRuntimeStateusing the published Agents API contract from feat(agents): add sandbox runtime state contract api#162.EnsureSandboxRunningrestart-on-connect behavior:runningandstartingreturn current sandboxstoppedandfailedtransition tostarting, clear stale workload id, publishsandbox.updated, and return the sandboxterminatedremains non-connectable with failed preconditionCloses #63
Refs agynio/architecture#162
Refs agynio/api#162
Validation
buf generate buf.build/agynio/api --include-imports --path agynio/api/agents/v1 --path agynio/api/authorization/v1 --path agynio/api/identity/v1 --path agynio/api/notifications/v1— passedgo test ./...— passedgo build ./...— passedgit diff --check— passed