Conversation
Chat v0.1.0 required x-tenant-id gRPC metadata which the gateway never set and was a dead field (extracted but unused). Chat v0.2.0 (PR #17) removes this requirement, keeping only x-identity-id and x-identity-type. Unblocks e2e tests in agynio/chat-app#38.
vitramir
previously approved these changes
Mar 24, 2026
Chat chart v0.2.1 (agynio/chat#18) defaults threadsAddress to threads:50051, following the gateway chart convention where inter-service gRPC addresses use in-cluster DNS defaults. Remove the v0.1.0-specific service.port and threads.address overrides — the chart defaults handle both correctly. This also removes the x-tenant-id requirement (dropped in chat v0.2.0, agynio/chat#17), unblocking real-API e2e tests in agynio/chat-app#38.
43ca91d to
bec2be3
Compare
The chat Docker workflow uses docker/metadata-action with
semver pattern={{version}} which strips the v prefix from tags.
Tag v0.2.1 produces image ghcr.io/agynio/chat:0.2.1 (no v).
Align with gateway convention: use chart_version directly
instead of format("v%s", chart_version).
vitramir
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
chat_chart_versionfrom0.1.0to0.2.1.What changed in chat v0.2.x
x-tenant-idmetadata requirement. Chat now only requiresx-identity-idandx-identity-type, which the gateway already provides.chat.threadsAddresstothreads:50051in the chart, following the gateway convention where inter-service gRPC targets default to in-cluster DNS names. Removes therequiredcheck that broke v0.2.0 deployments.Bootstrap changes
chat_chart_versiondefault from0.1.0to0.2.1service.portandthreads.addressoverrides — these were v0.1.0-specific values that no longer apply. The v0.2.1 chart defaults handle service ports (viaservice-baselibrary chart) and the threads address.Why
Unblocks real-API e2e tests in agynio/chat-app#38.
Diagnostic evidence from CI (v0.1.0):
Dependency
Requires agynio/chat#18 to be merged and tagged as
v0.2.1before this PR's CI can pass.