Merged
Conversation
Contributor
Author
Summary
Test & Lint
|
noa-lucent
approved these changes
Mar 21, 2026
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-scoped removal. All four files modified per the issue spec:
MetadataKeyTenantIDconstant,TenantIDstruct field, and extraction logic removed frominternal/identity/identity.go- Test helpers in
server_test.go,e2e_test.go, andmain_test.goupdated — all callers use the new signature - Verified zero remaining
tenant/x-tenant-idreferences in the codebase
No issues found. LGTM.
This was referenced Mar 22, 2026
emerson-gray
added a commit
to agynio/bootstrap
that referenced
this pull request
Mar 24, 2026
Chat chart v0.2.1 (agynio/chat#18) defaults threadsAddress to threads:50051, following the gateway chart convention where inter-service gRPC addresses use in-cluster DNS defaults. Remove the v0.1.0-specific service.port and threads.address overrides — the chart defaults handle both correctly. This also removes the x-tenant-id requirement (dropped in chat v0.2.0, agynio/chat#17), unblocking real-API e2e tests in agynio/chat-app#38.
vitramir
pushed a commit
to agynio/bootstrap
that referenced
this pull request
Mar 24, 2026
* chore: bump chat chart version to 0.2.0 Chat v0.1.0 required x-tenant-id gRPC metadata which the gateway never set and was a dead field (extracted but unused). Chat v0.2.0 (PR #17) removes this requirement, keeping only x-identity-id and x-identity-type. Unblocks e2e tests in agynio/chat-app#38. * chore: bump chat chart version to 0.2.1 Chat chart v0.2.1 (agynio/chat#18) defaults threadsAddress to threads:50051, following the gateway chart convention where inter-service gRPC addresses use in-cluster DNS defaults. Remove the v0.1.0-specific service.port and threads.address overrides — the chart defaults handle both correctly. This also removes the x-tenant-id requirement (dropped in chat v0.2.0, agynio/chat#17), unblocking real-API e2e tests in agynio/chat-app#38. * ci: re-trigger after chat v0.2.1 chart published * fix: drop v prefix from chat image tag resolution The chat Docker workflow uses docker/metadata-action with semver pattern={{version}} which strips the v prefix from tags. Tag v0.2.1 produces image ghcr.io/agynio/chat:0.2.1 (no v). Align with gateway convention: use chart_version directly instead of format("v%s", chart_version). * chore: bump chat chart to 0.2.2 (numeric UID fix) * fix: revert accidental notifications_chart_version bump --------- Co-authored-by: Emerson Gray <emerson.gray@agyn.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #16