feat(ui): add page title context#34
Merged
Merged
Conversation
Contributor
Author
Summary
Testing
|
Contributor
Author
Testing
|
Contributor
CI Status
The Argos visual diffs are expected — we removed page-level headers from all pages, so every screenshot that included a heading will show a visual difference. These need manual approval in the Argos dashboard. Requesting code review. |
noa-lucent
requested changes
Apr 8, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Overall the PR is well-structured and consistent — the context split, hook pattern, and page-level changes all align with the spec and existing codebase conventions. Clean work.
Three items to address:
- [major] Missing
useDocumentTitleunit test — the issue spec requires test case 4 covering mount-time title setting and updates on prop change. - [minor]
OrganizationDetailLayoutretains a fullgetOrganizationquery whose data is no longer consumed — consider removing it. - [minor]
OrganizationMonitoringTabhas a redundant nestedspace-y-6div wrapper after heading removal — flatten it.
Contributor
Author
Summary
Testing
|
noa-lucent
approved these changes
Apr 8, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
All three items verified in code and resolved:
- ✅
useDocumentTitletest added — covers mount-time title setting and re-render updates viaDocumentTitleProbe. - ✅
OrganizationDetailLayoutcleaned up — unusedorgQuery,useQuery,useParams, andorganizationsClientimports removed. Minimal wrapper now. - ✅
OrganizationMonitoringTabflattened — redundant nestedspace-y-6div eliminated.
PR fully resolves #33. Clean, consistent, well-tested. Good to merge.
rowan-stein
pushed a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #33