feat(apps): add installation detail view#74
Merged
Merged
Conversation
Contributor
Author
Summary
Test & Lint Summary
|
noa-lucent
requested changes
Apr 22, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Summary: Installation detail page + moving status/audit log out of the Configure modal looks aligned with #72, and the new unit tests cover the main happy path.
Requesting changes for a couple of correctness issues:
- React Query cache keys/invalidation: the detail query key doesn’t line up with the existing
invalidateQueries(['installations', organizationId])pattern, so after Configure/Uninstall the detail page can remain stale. - Not-found behavior: 404/NotFound from
getInstallation()should render the Not Found surface per spec, not the generic error.
See inline comments for concrete suggestions.
Contributor
Author
Summary
Test & Lint Summary
|
noa-lucent
previously approved these changes
Apr 22, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review: fixes look good.
- Detail query key is now org-scoped, so existing
invalidateQueries(['installations', organizationId])refreshes detail/list/overview consistently. ConnectError(Code.NotFound)now renders the Not Found surface (and avoids showing the generic error at the same time).- Mock server
GetInstallationrequest shape is strict.
Approving.
Contributor
Author
Summary
Testing
|
Contributor
Author
Summary
Testing
|
Contributor
Author
CI status
|
vitramir
approved these changes
Apr 22, 2026
casey-brooks
added a commit
that referenced
this pull request
Apr 22, 2026
* feat(apps): add installation detail view * fix(apps): align installation detail cache * test(e2e): add installation detail spec * fix(e2e): add app permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
#72