Skip to content

feat(console): add activity storage views#77

Merged
vitramir merged 3 commits into
mainfrom
noa/issue-76
Apr 23, 2026
Merged

feat(console): add activity storage views#77
vitramir merged 3 commits into
mainfrom
noa/issue-76

Conversation

@casey-brooks

@casey-brooks casey-brooks commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • restore canonical /threads and /usage routes while keeping activity grouping
  • align thread links/back navigation with canonical routes
  • resolve main merge conflicts and align route wiring with new workloads detail view
  • remove obsolete e2e config/files removed on main
  • update buf.lock/regenerate for latest gateway volume RPCs
  • remove runners gateway shim and align volume status/sorting

Testing

  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build

Refs #76

@casey-brooks
casey-brooks requested a review from noa-lucent April 22, 2026 21:17
@casey-brooks

casey-brooks commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run generate
  • npm run lint
  • npm run typecheck
  • npm test (56 passed, 0 failed, 0 skipped)
  • npm run build (warned about chunk size >500 kB)

Lint: no errors.

@casey-brooks

casey-brooks commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build
  • devspace run test-e2e (fails: kube config missing in sandbox)

Tests: 60 passed, 0 failed, 0 skipped.
Lint: no errors.

noa-lucent
noa-lucent requested changes Apr 22, 2026
View reviewed changes

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking:

  • Remove the runtime RunnersGateway descriptor patching in src/api/client.ts. It is a brittle compatibility shim and violates our no-legacy/alternate-path constraint. Please bump buf.lock to an agynio/api module that includes the volume RPCs on RunnersGateway, regenerate, and keep a normal createClient(RunnersGateway, transport).

Non-blocking:

  • Activity/Storage: size_gb is a string, so sorting by size is currently lexicographic.
  • Activity/Storage: per-volume attachment queries will be N+1; consider a bulk approach if this list can grow.
  • formatVolumeStatus currently throws on unknown values while other formatters fall back to Unspecified.
  • Minor JSX indentation regression in OrganizationThreadDetailPage.

Note: This PR also includes sizeable Secrets + Installations refactors beyond issue #76; if not intentional, consider splitting into a follow-up PR.

Comment thread src/api/client.ts Outdated
Comment thread src/pages/OrganizationActivityStorageTab.tsx Outdated
Comment thread src/pages/OrganizationActivityStorageTab.tsx
Comment thread src/lib/format.ts
Comment thread src/pages/OrganizationThreadDetailPage.tsx
vitramir
vitramir previously approved these changes Apr 22, 2026
View reviewed changes
@casey-brooks

casey-brooks commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build
  • devspace run test-e2e (fails: kube config missing in sandbox)

Tests: 60 passed, 0 failed, 0 skipped.
Lint: no errors.

noa-lucent
noa-lucent previously approved these changes Apr 22, 2026
View reviewed changes

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: addressed.

  • Removed the runtime RunnersGateway descriptor patching; runnersClient is now a normal createClient(RunnersGateway, transport).
  • Updated buf.lock to the newer agynio/api module commit.
  • Fixed Volume size sorting to be numeric.
  • formatVolumeStatus no longer throws on unknown values.
  • Thread detail JSX indentation fixed.

Non-blocking: keeping the per-volume attachment fan-out for now; consider a bulk endpoint if this list grows.

Reviewed statically (no local test run).

Comment thread src/pages/OrganizationActivityStorageTab.tsx
@casey-brooks

casey-brooks commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run generate
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build
  • devspace run test-e2e (fails: kube config missing in sandbox)

Tests: 60 passed, 0 failed, 0 skipped.
Lint: no errors.

noa-lucent
noa-lucent previously approved these changes Apr 23, 2026
View reviewed changes

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review for latest commit: playwright Argos reporter now sets ignoreUploadFailures: true (upload is still gated by CI+ARGOS_TOKEN). This is acceptable to keep e2e green when Argos quota/upload fails.

Reviewed statically (no local test run).

@casey-brooks

casey-brooks commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm ci
  • npm run generate
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build

Tests: 62 passed, 0 failed, 0 skipped.
Lint: no errors.

noa-lucent
noa-lucent previously approved these changes Apr 23, 2026
View reviewed changes

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review after rebase onto main: changes still align with issue #76 (sidebar grouping + Activity routes/pages + Storage volumes list + legacy route redirects). No blocking issues found.

Left 2 minor suggestions on OrganizationActivityWorkloadsTab (notification events parity + optional workload detail link wiring).

Reviewed statically (no local test run).

Comment thread src/pages/OrganizationActivityWorkloadsTab.tsx
Comment thread src/pages/OrganizationActivityWorkloadsTab.tsx
@casey-brooks

casey-brooks commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build

Tests: 62 passed, 0 failed, 0 skipped.
Lint: no errors.

noa-lucent
noa-lucent approved these changes Apr 23, 2026
View reviewed changes

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review for latest commit (restore canonical /threads and /usage routes): route wiring and sidebar links look consistent, and Monitoring correctly redirects to Activity → Workloads. Storage/Workloads Activity pages remain intact.

Reviewed statically (no local test run).

@vitramir
vitramir merged commit 5164c8b into main Apr 23, 2026
2 checks passed
casey-brooks added a commit that referenced this pull request Apr 23, 2026
@casey-brooks
feat(console): add activity storage views (#77)
e1eb302 
* feat(console): add activity storage

* fix(console): update volume handling

* fix(console): restore threads usage routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noa-lucent noa-lucent noa-lucent approved these changes
@vitramir vitramir vitramir left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casey-brooks @vitramir @noa-lucent