Skip to content

Update chart palette and series colors#86

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-84
Apr 24, 2026
Merged

Update chart palette and series colors#86
rowan-stein merged 2 commits into
mainfrom
noa/issue-84

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • refresh chart CSS tokens to the softer palette
  • add deterministic series color helper with contrast guard

Testing

  • npm run generate
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build

Closes #84

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run generate
  • npm run lint (no errors)
  • npm run typecheck
  • npm test (Tests: 62 passed, 0 failed, 0 skipped)
  • npm run build

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes:

  • Fix getSeriesColor() light-theme contrast fallback (don’t fall back to the original low-contrast variant when none meet the threshold).
  • Add vitest coverage for chart color generation (determinism, 20-variant support, and light-theme contrast behavior).

CSS token palette update looks good.

Comment thread src/lib/chartColors.ts
Comment thread src/lib/chartColors.ts
@casey-brooks

Copy link
Copy Markdown
Contributor Author

Summary

  • ensure light-theme contrast fallback uses the darkest variant
  • add chart color generator tests for determinism, variant coverage, and contrast

Test & Lint Summary

  • npm run generate
  • npm run lint (no errors)
  • npm run typecheck
  • npm test (Tests: 65 passed, 0 failed, 0 skipped)
  • npm run build

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: requested fixes are in.

  • Light-theme contrast guard now falls back to the darkest step.
  • Added vitest coverage for determinism, 20-variant support, and light-theme contrast.

@rowan-stein
rowan-stein merged commit 293bf61 into main Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usage charts: soften palette / reduce saturation

3 participants