Skip to content

[AAASM-4725] 📝 (examples): Fix stale rc.3 rationale comment on the SDK pin#317

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4725/fix_stale_rc3_comment
Jul 16, 2026
Merged

[AAASM-4725] 📝 (examples): Fix stale rc.3 rationale comment on the SDK pin#317
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4725/fix_stale_rc3_comment

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

What changed

Corrects a stale rationale comment in python/microsoft-agent-framework-tool-policy/pyproject.toml. The SDK pin is already correct (agent-assembly==0.0.1rc5), but the WHY-comment above it still said "0.0.1rc3 remains the latest installable version on PyPI" — written before rc.4/rc.5 shipped, so it contradicted its own pin. One-token fix (rc3 → rc5); no pin change, no behavior change.

Related ticket

Closes AAASM-4725

How to verify

  • git diff shows a single comment-line change; the pin agent-assembly==0.0.1rc5 is untouched.
  • Running the metadata generator produces no new changes (the comment is not a version-bearing surface); --check stays exit 0; the 32 generator unit tests still pass.

Checklist

  • PR title follows [AAASM-XXXX] <GitEmoji> (<scope>): <summary>
  • No secrets, API keys, or .env files committed
  • Example sub-projects include their own README.md (unchanged)
  • SDK/runtime version dependencies are documented or pinned (this corrects the pin's rationale comment)

@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

Review (AAASM-4725) — READY.

  • CI: all checks green (25) and the SonarCloud quality gate passed; the metadata drift-check is green (confirms the generator stays idempotent).
  • Scope: covers the ticket exactly — the stale rationale comment now reads rc.5 (matching the already-correct pin). One-line change.
  • Side effects: none. The changed-files list is a single file, +1/-1, and it's a comment line only; the pin agent-assembly==0.0.1rc5 is untouched, so nothing about dependency resolution, the generator, or CI behavior changes. No existing function or business logic affected.
  • Front end: none — a Python manifest comment, so Playwright validation is not applicable.

Base master; awaiting Pioneer review — not merged.

— Reviewed by Claude Code

@Chisanan232
Chisanan232 merged commit f7bb40f into master Jul 16, 2026
26 checks passed
@Chisanan232
Chisanan232 deleted the v0.0.1/AAASM-4725/fix_stale_rc3_comment branch July 16, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant