fix(aidd-context): make 10-learn's recommendation step consistent - #622
Merged
blafourcade merged 1 commit intoAug 12, 2026
Merged
Conversation
… enforce scope The confirm step rendered differently every run (full table, bare list, or an approval prompt with nothing shown first) and sometimes proposed learnings outside the current PR or logged a fixed bug as a decision. - assess always fills a fixed recommendation-table asset (Packet/Score/ Destination/Reconciliation, one bare value per cell) before asking approve/modify/skip, never the reverse - gather drops signals outside the source's scope and bugs fixed without an explicit request to remember them - destinations gain a `contract` case (amend an existing project contract file directly, e.g. skill-authoring.md) and reconciliation gains `retracts` (remove, no replacement), each with a real apply rule - write-report asset gives 04-write a fixed add/modify/remove report, matching the emoji convention already used in 01-plan - dedup pass across router/actions/references: removed restated rules, merged near-duplicate destination rows, closed a gap where the assess step never emitted a source scope for gather to filter against Fixes #561 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
The
10-learnconfirm step rendered differently every run (full table, bare list, or a question with nothing shown first) and sometimes proposed learnings outside the current PR or logged a fixed bug as a decision.🛠️ How it works
assessalways fills a fixedrecommendation-table.mdasset (Packet/Score/Destination/Reconciliation, one bare value per cell, no parentheses or invented text) before asking approve/modify/skip — never the reverse.gather-protocol.mddrops signals outside the source's scope and bugs already fixed without an explicit request to remember them — the two behaviors fix(aidd learn): Inconstancy et bypass user demande #561 actually reported.destinations.mdgains acontractcase (amend an existing project contract file directly, e.g.skill-authoring.md) and reconciliation gainsretracts(remove, no replacement), each with a real apply rule and a matchingreview-protocol.mdcheck.write-report.mdgives04-writea fixed add/modify/remove report, reusing the emoji convention already used in01-plan'sphase-template.md.ruledestination row, and closed a gap whereassessnever actually emitted a source scope forgatherto filter against — the scope-drop rule above was silently inert without it.Verified end to end with headless
claude -pruns (real diff as source, missing source, no-candidate source, format-consistency across two different source kinds) and live interactive runs after each fix. Two things stayed out of scope on purpose: the model narrating its Gather reasoning before the table, and occasionally pausing between actions instead of running the whole flow in one pass — both look like harness-level turn behavior (the exact same router boilerplate is used verbatim by 11 other skills in this repo), not something a skill markdown file can reliably suppress.🧪 How to verify
node scripts/check-markdown-links.js— 0 broken.make reload PLUGIN=aidd-context && claude -p "/aidd-context:10-learn diff"on a branch with real changes — confirm rec table shows before any question, bare cell values, correct destination.plugins/aidd-context/CATALOG.mdis auto-regenerated as part of this diff (two new assets).🔗 Linked issue
Closes #561
✅ I certify