Closed
Conversation
Owner
|
Author
|
Owner
Maybe this task is not for Linux users. I have Linux too and created this task because I don't know how to create a beautiful video in Linux |
ai
reviewed
Jul 30, 2024
| return ( | ||
| <div> | ||
| <input aria-keyshortcuts="f" placeholder="f" type="text" /> | ||
| <input aria-keyshortcuts="shift+s" placeholder="S" type="text" /> |
Owner
There was a problem hiding this comment.
Yo have different hotkey in aria-keyshortcuts and placeholder
ai
reviewed
Jul 30, 2024
| <> | ||
| <input aria-controls="results" placeholder="Search" type="search" /> | ||
| <ul id="results" role="listbox"> | ||
| <ul id="results" aria-keyshortcuts="i" role="listbox"> |
Owner
There was a problem hiding this comment.
You should move focus here by pressing Enter in search field
Owner
|
I am closing this PR in favor of #28 Please open other PR with the fix and issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've added the demo version. Also in the process I found a bunch of errors on your demo page:
k) button.esckey should bring the focus area back. My understanding is thattabkey: jump to the first element on the page,tabkey: jump to the next elementI think that's it. I hope my PR will be useful.