Skip to content

add demo video#27

Closed
uzurpastor wants to merge 4 commits intoai:mainfrom
uzurpastor:main
Closed

add demo video#27
uzurpastor wants to merge 4 commits intoai:mainfrom
uzurpastor:main

Conversation

@uzurpastor
Copy link

@uzurpastor uzurpastor commented Jul 30, 2024

Hi, I've added the demo version. Also in the process I found a bunch of errors on your demo page:

  • in focus/jumping mode, it is impossible to focus on the ‘list2’(k) button.
  • the inherited ‘About’ menu is not displayed (fixed in this PR)
  • as stated here, the esc key should bring the focus area back. My understanding is that
    • expected:
      • clear information about the last focused element
      • when pressing the tab key: jump to the first element on the page,
    • current:
      • hiding the blue frame
      • when you press the tab key: jump to the next element

I think that's it. I hope my PR will be useful.

@ai
Copy link
Owner

ai commented Jul 30, 2024

  1. Don't do different things in a single PR. Please open new PR with fixes.
  2. Open new issue with issue report.
  3. The panel with pressed key is not very easy to understand because it renders arrows as letters.

@uzurpastor
Copy link
Author

uzurpastor commented Jul 30, 2024

  1. yep
  2. yep
  3. Not sure if it be possible to implement from my side. I researched actual key showers for Linux systems and this one "showmethekey" works good. But there is a bit unclear manual about how to run with utf8 encoding. if the issue would be actual tomorrow, I'll try then because it can take a time.

@ai
Copy link
Owner

ai commented Jul 30, 2024

Not sure if it be possible to implement from my side. I researched actual key showers for Linux systems and this one "showmethekey" works good. But there is a bit unclear manual about how to run with utf8 encoding. if the issue would be actual tomorrow, I'll try then because it can take a time.

Maybe this task is not for Linux users. I have Linux too and created this task because I don't know how to create a beautiful video in Linux

return (
<div>
<input aria-keyshortcuts="f" placeholder="f" type="text" />
<input aria-keyshortcuts="shift+s" placeholder="S" type="text" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo have different hotkey in aria-keyshortcuts and placeholder

<>
<input aria-controls="results" placeholder="Search" type="search" />
<ul id="results" role="listbox">
<ul id="results" aria-keyshortcuts="i" role="listbox">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move focus here by pressing Enter in search field

@ai
Copy link
Owner

ai commented Aug 1, 2024

I am closing this PR in favor of #28

Please open other PR with the fix and issue.

@ai ai closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants