Add limited support for focusgroup attribute#45
Closed
echo-vladimir wants to merge 2 commits intoai:mainfrom
Closed
Add limited support for focusgroup attribute#45echo-vladimir wants to merge 2 commits intoai:mainfrom
echo-vladimir wants to merge 2 commits intoai:mainfrom
Conversation
ai
reviewed
Oct 28, 2024
- Add inline and block support
ai
reviewed
Oct 28, 2024
| function isHorizontalOrientation(group) { | ||
| let focusGroupValue = group.getAttribute('focusgroup') | ||
| if (focusGroupValue === 'inline') return true | ||
| if (focusGroupValue === 'block') return false |
Owner
There was a problem hiding this comment.
What is focusgroup has no inline or block? Some value should be by default?
Please, don’t rush. Read spec more careful and think twice and deeper.
ai
reviewed
Oct 28, 2024
| if (group.role === 'toolbar') return getToolbarItems(group) | ||
| return group.querySelectorAll(`[role=${target.role}]`) | ||
| if (group.hasAttribute('focusgroup')) { | ||
| return [...group.children] |
Owner
There was a problem hiding this comment.
Are you sure, that all children should be focusable?
- What is some
childrenis not focusable (like<h2>)? - Can you double-check that we don't need similar logic to
getToolbarItems?
Owner
|
Sorry, this PR was faster #46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.