Conversation
eeberhard
approved these changes
Dec 18, 2023
Member
eeberhard
left a comment
eeberhard
left a comment
There was a problem hiding this comment.
Seems reasonable, an easy thing to miss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From what I can see in https://github.com/aica-technology/hardware-collections/actions/runs/7246654042/job/19739015041 and in the parse-package-toml action
cmd: yq '.metadata.name' ${{ inputs.directory }}/aica-package.toml, I think the input to this action should not be/tmp/but/tmpReview guidelines
Estimated Time of Review: 2 minutes
Checklist before merging: