fix(parse-package-toml): fix the action for new version of package-builder#45
Merged
LouisBrunner merged 1 commit intomainfrom Jun 11, 2024
Merged
Conversation
domire8
approved these changes
Jun 11, 2024
Member
domire8
left a comment
domire8
left a comment
There was a problem hiding this comment.
Looks good, I trust your call for the version. I will have to update all collections asap then
jjenscodee
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raised by @domire8
This PR adapts the
parse-package-tomlto the new version ofpackage-builder(v1 and later).Main question: what version should we release this with? As it is a breaking change, should we go to
v1.0.0? The issue is that all actions use the same version, so not sure if semver actually make sense?Review guidelines
Estimated Time of Review: 3 minutes