Skip to content

fix: replace bad bun workflow with an action#51

Merged
LouisBrunner merged 2 commits intomainfrom
feat/bun-act
Jan 14, 2025
Merged

fix: replace bad bun workflow with an action#51
LouisBrunner merged 2 commits intomainfrom
feat/bun-act

Conversation

@LouisBrunner
Copy link
Copy Markdown
Contributor

Description

Previous workflow had a lot of issues:

  • No workflow_call (meaning we can't have the event filtering here)
  • Rely on FE action to setup the bun env
  • If we need an action before, it can't be a workflow
  • If it can't be a workflow, it can't have permissions or if on the job either

Review guidelines

Estimated Time of Review: 3 minutes

@LouisBrunner LouisBrunner self-assigned this Jan 14, 2025
@LouisBrunner LouisBrunner merged commit 12a0e84 into main Jan 14, 2025
@domire8 domire8 deleted the feat/bun-act branch January 14, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants